Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753229AbdHPCUb (ORCPT ); Tue, 15 Aug 2017 22:20:31 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:31830 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752401AbdHPCUa (ORCPT ); Tue, 15 Aug 2017 22:20:30 -0400 Message-ID: <1502850023.19230.42.camel@mtkswgap22> Subject: Re: [PATCH v3 1/2] dt-bindings: i2c: Add MediaTek MT7622 i2c binding From: Sean Wang To: Jun Gao CC: Wolfram Sang , Matthias Brugger , , , , , , Date: Wed, 16 Aug 2017 10:20:23 +0800 In-Reply-To: <1502802495-5064-2-git-send-email-jun.gao@mediatek.com> References: <1502802495-5064-1-git-send-email-jun.gao@mediatek.com> <1502802495-5064-2-git-send-email-jun.gao@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1980 Lines: 48 On Tue, 2017-08-15 at 21:08 +0800, Jun Gao wrote: > From: Jun Gao > > Add MT7622 i2c binding to binding file and change the compatible > information formats of all SoCs to the same. > > Signed-off-by: Jun Gao > --- > Documentation/devicetree/bindings/i2c/i2c-mtk.txt | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-mtk.txt b/Documentation/devicetree/bindings/i2c/i2c-mtk.txt > index bd5a7be..71fc0b3 100644 > --- a/Documentation/devicetree/bindings/i2c/i2c-mtk.txt > +++ b/Documentation/devicetree/bindings/i2c/i2c-mtk.txt > @@ -4,11 +4,12 @@ The Mediatek's I2C controller is used to interface with I2C devices. > > Required properties: > - compatible: value should be either of the following. > - "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek mt2701 > - "mediatek,mt6577-i2c": for i2c compatible with mt6577. > - "mediatek,mt6589-i2c": for i2c compatible with mt6589. > - "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for i2c compatible with mt7623. > - "mediatek,mt8173-i2c": for i2c compatible with mt8173. > + "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek MT2701 > + "mediatek,mt6577-i2c": for Mediatek MT6577 > + "mediatek,mt6589-i2c": for Mediatek MT6589 > + "mediatek,mt7622-i2c": for Mediatek MT7622 > + "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for Mediatek MT7623 > + "mediatek,mt8173-i2c": for Mediatek MT8173 > - reg: physical base address of the controller and dma base, length of memory > mapped region. > - interrupts: interrupt number to the cpu. Hi, Jun the patch for new soc support and clean-ups should better be in separate patch following previous Matthias suggestion. http://lists.infradead.org/pipermail/linux-mediatek/2017-August/009740.html And also spelling for Mediatek should be corrected using MediaTek. Sean