Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753059AbdHPDP3 (ORCPT ); Tue, 15 Aug 2017 23:15:29 -0400 Received: from regular1.263xmail.com ([211.150.99.141]:56089 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751692AbdHPDP2 (ORCPT ); Tue, 15 Aug 2017 23:15:28 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: wxt@rock-chips.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: <3a9b4e0fa26395ceff1bea025c1d114f> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH] arm64: dts: rk3399: init vop clock rates To: Kever Yang , heiko@sntech.de References: <1502851869-1736-1-git-send-email-kever.yang@rock-chips.com> Cc: Mark Rutland , devicetree@vger.kernel.org, Elaine Zhang , Jacob Chen , linux-kernel@vger.kernel.org, Shawn Lin , Brian Norris , Will Deacon , Douglas Anderson , linux-rockchip@lists.infradead.org, Rob Herring , Roger Chen , Catalin Marinas , William wu , linux-arm-kernel@lists.infradead.org, Caesar Wang From: Mark yao Message-ID: <5993B8BF.9020100@rock-chips.com> Date: Wed, 16 Aug 2017 11:15:11 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1502851869-1736-1-git-send-email-kever.yang@rock-chips.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1543 Lines: 40 On 2017年08月16日 10:51, Kever Yang wrote: > We need to init vop aclk and hclk incase the U-Boot does not do > the initialize. > > Signed-off-by: Kever Yang > --- Looks good for me: Reviewed-by: Mark Yao > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > index 0b3acc9..a592c24 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > @@ -1480,6 +1480,8 @@ > interrupts = ; > clocks = <&cru ACLK_VOP1>, <&cru DCLK_VOP1>, <&cru HCLK_VOP1>; > clock-names = "aclk_vop", "dclk_vop", "hclk_vop"; > + assigned-clocks = <&cru ACLK_VOP1>, <&cru HCLK_VOP1>; > + assigned-clock-rates = <400000000>, <100000000>; > iommus = <&vopl_mmu>; > power-domains = <&power RK3399_PD_VOPL>; > resets = <&cru SRST_A_VOP1>, <&cru SRST_H_VOP1>, <&cru SRST_D_VOP1>; > @@ -1525,6 +1527,8 @@ > interrupts = ; > clocks = <&cru ACLK_VOP0>, <&cru DCLK_VOP0>, <&cru HCLK_VOP0>; > clock-names = "aclk_vop", "dclk_vop", "hclk_vop"; > + assigned-clocks = <&cru ACLK_VOP0>, <&cru HCLK_VOP0>; > + assigned-clock-rates = <400000000>, <100000000>; > iommus = <&vopb_mmu>; > power-domains = <&power RK3399_PD_VOPB>; > resets = <&cru SRST_A_VOP0>, <&cru SRST_H_VOP0>, <&cru SRST_D_VOP0>; -- Ｍark Yao