Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753485AbdHPD0D (ORCPT ); Tue, 15 Aug 2017 23:26:03 -0400 Received: from mail-pg0-f48.google.com ([74.125.83.48]:36800 "EHLO mail-pg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753051AbdHPD0C (ORCPT ); Tue, 15 Aug 2017 23:26:02 -0400 Date: Wed, 16 Aug 2017 08:55:59 +0530 From: Viresh Kumar To: Arvind Yadav Cc: rjw@rjwysocki.net, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH] CPUFREQ: Loongson2: constify platform_device_id Message-ID: <20170816032559.GB4233@vireshk-i7> References: <38726390c030dc256d7dd169a416bc4a9814cbf7.1502617113.git.arvind.yadav.cs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <38726390c030dc256d7dd169a416bc4a9814cbf7.1502617113.git.arvind.yadav.cs@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1003 Lines: 29 On 13-08-17, 15:10, Arvind Yadav wrote: > platform_device_id are not supposed to change at runtime. All functions > working with platform_device_id provided by > work with const platform_device_id. So mark the non-const structs as > const. > > Signed-off-by: Arvind Yadav > --- > drivers/cpufreq/loongson2_cpufreq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/loongson2_cpufreq.c b/drivers/cpufreq/loongson2_cpufreq.c > index 9ac27b2..da34469 100644 > --- a/drivers/cpufreq/loongson2_cpufreq.c > +++ b/drivers/cpufreq/loongson2_cpufreq.c > @@ -114,7 +114,7 @@ static struct cpufreq_driver loongson2_cpufreq_driver = { > .attr = cpufreq_generic_attr, > }; > > -static struct platform_device_id platform_device_ids[] = { > +static const struct platform_device_id platform_device_ids[] = { > { > .name = "loongson2_cpufreq", > }, Acked-by: Viresh Kumar -- viresh