Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751943AbdHPGI4 (ORCPT ); Wed, 16 Aug 2017 02:08:56 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:58932 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751772AbdHPGIy (ORCPT ); Wed, 16 Aug 2017 02:08:54 -0400 From: Thomas Richter To: john.stultz@linaro.org, tglx@linutronix.de, linux-kernel@vger.kernel.org Cc: brueckner@linux.vnet.ibm.com, heiko.carstens@de.ibm.com, schwidefsky@de.ibm.com, Thomas Richter Subject: [PATCH] tools: fix compile error of freq-step.c Date: Wed, 16 Aug 2017 08:08:37 +0200 X-Mailer: git-send-email 2.11.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 17081606-0016-0000-0000-000004E41799 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17081606-0017-0000-0000-0000281D241F Message-Id: <20170816060837.16612-1-tmricht@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-08-16_02:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1708160104 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1636 Lines: 50 The compilation of the file freq-step.c in directory tools/testing/selftests/timers fails with this error message: [root@s8360046 timers]# make gcc -O3 -Wl,-no-as-needed -Wall -DKTEST -lrt -lpthread -lm freq-step.c -o freq-step freq-step.c: In function ‘init_test’: freq-step.c:234:3: error: too few arguments to function ‘ksft_exit_skip’ ksft_exit_skip(); ^~~~~~~~~~~~~~ In file included from freq-step.c:26:0: ../kselftest.h:142:19: note: declared here static inline int ksft_exit_skip(const char *msg, ...) ^~~~~~~~~~~~~~ : recipe for target 'freq-step' failed make: *** [freq-step] Error 1 [root@s8360046 timers]# This is the case for Intel and s390x. I have not tested other platforms. Which this patch the compilation succeeds: [root@s8360046 timers]# make gcc -O3 -Wl,-no-as-needed -Wall -DKTEST -lrt -lpthread -lm freq-step.c -o freq-step [root@s8360046 timers]# ./freq-step CLOCK_MONOTONIC_RAW+CLOCK_MONOTONIC precision: 348 ns [SKIP] 1..0 # Skipped: [SKIP] [root@s8360046 timers]# Signed-off-by: Thomas Richter --- tools/testing/selftests/timers/freq-step.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/timers/freq-step.c b/tools/testing/selftests/timers/freq-step.c index e8c6183..bda9744 100644 --- a/tools/testing/selftests/timers/freq-step.c +++ b/tools/testing/selftests/timers/freq-step.c @@ -231,7 +231,7 @@ static void init_test(void) if (precision > MAX_PRECISION) { printf("[SKIP]\n"); - ksft_exit_skip(); + ksft_exit_skip("[SKIP]\n"); } printf("[OK]\n"); -- 2.9.3