Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751661AbdHPHRn (ORCPT ); Wed, 16 Aug 2017 03:17:43 -0400 Received: from kvm5.telegraphics.com.au ([98.124.60.144]:54318 "EHLO kvm5.telegraphics.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751224AbdHPHRl (ORCPT ); Wed, 16 Aug 2017 03:17:41 -0400 Date: Wed, 16 Aug 2017 17:17:43 +1000 (AEST) From: Finn Thain To: Arvind Yadav cc: schmitzmic@gmail.com, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH] scsi: ncr5380: constify pnp_device_id In-Reply-To: <1125161eb43bc7ee7f748a040ab06b40cc1537dd.1502859040.git.arvind.yadav.cs@gmail.com> Message-ID: References: <60c34272432b3411cd5d55728c62481e133f32a6.1502859040.git.arvind.yadav.cs@gmail.com> <1125161eb43bc7ee7f748a040ab06b40cc1537dd.1502859040.git.arvind.yadav.cs@gmail.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 929 Lines: 28 On Wed, 16 Aug 2017, Arvind Yadav wrote: > pnp_device_id are not supposed to change at runtime. All functions > working with pnp_device_id provided by work with > const pnp_device_id. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav Acked-by: Finn Thain > --- > drivers/scsi/g_NCR5380.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/g_NCR5380.c b/drivers/scsi/g_NCR5380.c > index c34fc91..1968d81 100644 > --- a/drivers/scsi/g_NCR5380.c > +++ b/drivers/scsi/g_NCR5380.c > @@ -703,7 +703,7 @@ static struct isa_driver generic_NCR5380_isa_driver = { > }; > > #ifdef CONFIG_PNP > -static struct pnp_device_id generic_NCR5380_pnp_ids[] = { > +static const struct pnp_device_id generic_NCR5380_pnp_ids[] = { > { .id = "DTC436e", .driver_data = BOARD_DTC3181E }, > { .id = "" } > }; >