Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751678AbdHPHbW (ORCPT <rfc822;w@1wt.eu>);
        Wed, 16 Aug 2017 03:31:22 -0400
Received: from userp1040.oracle.com ([156.151.31.81]:36031 "EHLO
        userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751611AbdHPHbV (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 16 Aug 2017 03:31:21 -0400
Date: Wed, 16 Aug 2017 10:31:06 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Rishabh Hardas <rishabhhardas@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org, rjosephwright@gmail.com,
        linux@Wolf-Entwicklungen.de, colin.king@canonical.com
Subject: Re: [PATCH v2 1/4] staging: pi433: Style fix - Correct long lines
Message-ID: <20170816073106.vyhezn7f2recdarp@mwanda>
References: <cover.1501759442.git.rishabhhardas@gmail.com>
 <2adda87146ff5161e33f0379c662908ecc1f3e0a.1501759442.git.rishabhhardas@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2adda87146ff5161e33f0379c662908ecc1f3e0a.1501759442.git.rishabhhardas@gmail.com>
User-Agent: NeoMutt/20170113 (1.7.2)
X-Source-IP: aserv0021.oracle.com [141.146.126.233]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1175
Lines: 24

On Wed, Aug 16, 2017 at 10:53:18AM +0530, Rishabh Hardas wrote:
> @@ -143,10 +142,13 @@ struct pi433_rx_cfg {
> 
>  #define PI433_IOC_MAGIC			'r'
> 
> -#define PI433_IOC_RD_TX_CFG	_IOR(PI433_IOC_MAGIC, PI433_TX_CFG_IOCTL_NR, char[sizeof(struct pi433_tx_cfg)])
> -#define PI433_IOC_WR_TX_CFG	_IOW(PI433_IOC_MAGIC, PI433_TX_CFG_IOCTL_NR, char[sizeof(struct pi433_tx_cfg)])
> -
> -#define PI433_IOC_RD_RX_CFG	_IOR(PI433_IOC_MAGIC, PI433_RX_CFG_IOCTL_NR, char[sizeof(struct pi433_rx_cfg)])
> -#define PI433_IOC_WR_RX_CFG	_IOW(PI433_IOC_MAGIC, PI433_RX_CFG_IOCTL_NR, char[sizeof(struct pi433_rx_cfg)])
> +#define PI433_IOC_RD_TX_CFG	_IOR(PI433_IOC_MAGIC, PI433_TX_CFG_IOCTL_NR,\
> +				     char[sizeof(struct pi433_tx_cfg)])
> +#define PI433_IOC_WR_TX_CFG	_IOW(PI433_IOC_MAGIC, PI433_TX_CFG_IOCTL_NR,\
> +				     char[sizeof(struct pi433_tx_cfg)])
> +#define PI433_IOC_RD_RX_CFG	_IOR(PI433_IOC_MAGIC, PI433_RX_CFG_IOCTL_NR,\
> +				     char[sizeof(struct pi433_rx_cfg)])
> +#define PI433_IOC_WR_RX_CFG	_IOW(PI433_IOC_MAGIC, PI433_RX_CFG_IOCTL_NR,\
> +				     char[sizeof(struct pi433_rx_cfg)])


These don't help readability.  The original was better.

regards,
dan carpenter