Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751531AbdHPHe0 (ORCPT ); Wed, 16 Aug 2017 03:34:26 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:37484 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751068AbdHPHeZ (ORCPT ); Wed, 16 Aug 2017 03:34:25 -0400 Date: Wed, 16 Aug 2017 10:34:13 +0300 From: Dan Carpenter To: Rishabh Hardas Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, rjosephwright@gmail.com, linux@Wolf-Entwicklungen.de, colin.king@canonical.com Subject: Re: [PATCH v2 3/4] staging: pi433: Renaming Enums Message-ID: <20170816073413.b2lll5daflcje2kl@mwanda> References: <1bb3eea9cfefad627039c14b26de433d37bab51e.1501759442.git.rishabhhardas@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1bb3eea9cfefad627039c14b26de433d37bab51e.1501759442.git.rishabhhardas@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 949 Lines: 26 On Wed, Aug 16, 2017 at 10:53:20AM +0530, Rishabh Hardas wrote: > Remove camel casing by renaming enums. > > Signed-off-by: Rishabh Hardas > --- > drivers/staging/pi433/pi433_if.h | 36 ++++++++++++++++-------------------- > drivers/staging/pi433/rf69.c | 26 +++++++++++++------------- > drivers/staging/pi433/rf69.h | 26 +++++++++++++------------- > drivers/staging/pi433/rf69_enum.h | 16 ++++++++-------- > 4 files changed, 50 insertions(+), 54 deletions(-) > > diff --git a/drivers/staging/pi433/pi433_if.h b/drivers/staging/pi433/pi433_if.h > index 84032f3..2929de0 100644 > --- a/drivers/staging/pi433/pi433_if.h > +++ b/drivers/staging/pi433/pi433_if.h > @@ -62,21 +62,20 @@ struct pi433_tx_cfg { > __u16 bit_rate; > __u32 dev_frequency; > enum modulation modulation; > - enum modShaping modShaping; > + enum mod_shaping modShaping; Now the names don't line up. regards, dan carpenter