Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751780AbdHPHfd (ORCPT ); Wed, 16 Aug 2017 03:35:33 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:38069 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751624AbdHPHfc (ORCPT ); Wed, 16 Aug 2017 03:35:32 -0400 Date: Wed, 16 Aug 2017 10:35:15 +0300 From: Dan Carpenter To: Rishabh Hardas Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, rjosephwright@gmail.com, linux@Wolf-Entwicklungen.de, colin.king@canonical.com Subject: Re: [PATCH v2 2/4] staging: pi433: Change Comments Message-ID: <20170816073515.giuc4bsjzxs3brvo@mwanda> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 284 Lines: 11 On Wed, Aug 16, 2017 at 10:53:19AM +0530, Rishabh Hardas wrote: > + enum optionOnOff enable_crc; /* only operational, > + *if sync on and fixed > + * length or length > + * byte is used > + */ This could be done better. regards, dan carpenter