Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751731AbdHPID7 (ORCPT <rfc822;w@1wt.eu>);
        Wed, 16 Aug 2017 04:03:59 -0400
Received: from szxga04-in.huawei.com ([45.249.212.190]:3983 "EHLO
        szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751454AbdHPIDw (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 16 Aug 2017 04:03:52 -0400
Subject: Re: [PATCH v2] acpi: apei: fix the wrongly iterate generic error
 status block
To: "Baicar, Tyler" <tbaicar@codeaurora.org>,
        gengdongjiu <gengdj.1984@gmail.com>
References: <1502795713-20945-1-git-send-email-gengdongjiu@huawei.com>
 <CAMj-D2CXOurgPGGGbC7qHX-uWZeMYwh9EfLOS3p3hm+=BvPq7w@mail.gmail.com>
 <20170815161342.jxxf4rndqbs7t5rr@pd.tnic>
 <CAMj-D2AHjR70Fy61aBxof7AxnW+Bz_YgJq-5yOdK+VV8uaF3bA@mail.gmail.com>
 <20170815163239.xm5y6w5yeiaakekv@pd.tnic>
 <CAMj-D2C2S=RoZ7TyhnyX598nHH9xwKQt23mV+u=1tV3+YMMVsQ@mail.gmail.com>
 <20170815165551.4cwa344wm6eptj3d@pd.tnic>
 <7921a233-6971-6e3b-9164-01d6176d61c0@codeaurora.org>
 <CAMj-D2DDMYBJY5aW38Q=y+J59d-0tAy0JhmdP8goHKAbJSedag@mail.gmail.com>
 <3747a14c-0801-fe10-f36e-af6458fd7bdf@codeaurora.org>
CC: Borislav Petkov <bp@suse.de>, <rjw@rjwysocki.net>,
        Len Brown <lenb@kernel.org>, <linux-acpi@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linuxarm@huawei.com>,
        John Garry <john.garry@huawei.com>, Shiju Jose <shiju.jose@huawei.com>,
        <zhengqiang10@huawei.com>, Xiongfeng Wang <wangxiongfeng2@huawei.com>,
        Huangshaoyu <huangshaoyu@huawei.com>,
        wuquanming <wuquanming@huawei.com>, James Morse <james.morse@arm.com>,
        Geliang Tang <geliangtang@gmail.com>,
        <andriy.shevchenko@linux.intel.com>, <tony.luck@intel.com>,
        <austinwc@codeaurora.org>, <shameerali.kolothum.thodi@huawei.com>,
        <jonathan.cameron@huawei.com>, <huangdaode@hisilicon.com>,
        <wangzhou1@hisilicon.com>
From: gengdongjiu <gengdongjiu@huawei.com>
Message-ID: <cff53642-79bb-ea85-507f-28ba100ced73@huawei.com>
Date: Wed, 16 Aug 2017 16:03:13 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.1
MIME-Version: 1.0
In-Reply-To: <3747a14c-0801-fe10-f36e-af6458fd7bdf@codeaurora.org>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.142.68.147]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
        refid=str=0001.0A090206.5993FC50.0019,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
        ip=0.0.0.0,
        so=2014-11-16 11:51:01,
        dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: 3f35fb07657d180ddf07c95298a34858
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1017
Lines: 27

Hello Tyler,
  I have already updated a new version patch to adds this usage to cper_estatus_check(), please re-test.

Hello Boris,
  The original macro of apei_estatus_for_each_section has two issues:
one is the iteration loop termination condition; another is the iteration steps. please review it.
thanks.



On 2017/8/16 7:26, Baicar, Tyler wrote:
> On 8/15/2017 3:34 PM, gengdongjiu wrote:
>> Hi Tyler ,
>>
>>> Hello Boris,
>>>
>>> His patch fixes the define for apei_estatus_for_each_section which in turn
>>> should fix ghes_do_proc(). So my patch should no longer be needed. I'm going
>>> to test this out just to verify if fixes the issue I found.
>> I have verified the issue about the iteration for the revision 0x300
>> generic error data,
>> it works well. it is good that you will verify that in your  platform.
> I've verified that this resolves the issue as well! I'll re-test with the next version that adds this usage to cper_estatus_check() and add my tested-by after that.
> 
> Thanks,
> Tyler
>