Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751584AbdHPILz (ORCPT ); Wed, 16 Aug 2017 04:11:55 -0400 Received: from mail-oi0-f44.google.com ([209.85.218.44]:34837 "EHLO mail-oi0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751068AbdHPILx (ORCPT ); Wed, 16 Aug 2017 04:11:53 -0400 MIME-Version: 1.0 In-Reply-To: <20170816045059.GD24294@blaptop> References: <1502704590-3129-1-git-send-email-zhuhui@xiaomi.com> <20170816021339.GA23451@blaptop> <20170816045059.GD24294@blaptop> From: Hui Zhu Date: Wed, 16 Aug 2017 16:11:11 +0800 Message-ID: Subject: Re: [PATCH v2] zsmalloc: zs_page_migrate: schedule free_work if zspage is ZS_EMPTY To: Minchan Kim Cc: Hui Zhu , "ngupta@vflare.org" , Sergey Senozhatsky , Linux Memory Management List , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1287 Lines: 39 2017-08-16 12:51 GMT+08:00 Minchan Kim : > On Wed, Aug 16, 2017 at 10:49:14AM +0800, Hui Zhu wrote: >> Hi Minchan, >> >> 2017-08-16 10:13 GMT+08:00 Minchan Kim : >> > Hi Hui, >> > >> > On Mon, Aug 14, 2017 at 05:56:30PM +0800, Hui Zhu wrote: >> >> After commit e2846124f9a2 ("zsmalloc: zs_page_migrate: skip unnecessary >> > >> > This patch is not merged yet so the hash is invalid. >> > That means we may fold this patch to [1] in current mmotm. >> > >> > [1] zsmalloc-zs_page_migrate-skip-unnecessary-loops-but-not-return-ebusy-if-zspage-is-not-inuse-fix.patch >> > >> >> loops but not return -EBUSY if zspage is not inuse") zs_page_migrate >> >> can handle the ZS_EMPTY zspage. >> >> >> >> But I got some false in zs_page_isolate: >> >> if (get_zspage_inuse(zspage) == 0) { >> >> spin_unlock(&class->lock); >> >> return false; >> >> } >> > >> > I also realized we should make zs_page_isolate succeed on empty zspage >> > because we allow the empty zspage migration from now on. >> > Could you send a patch for that as well? >> >> OK. I will make a patch for that later. > > Please send the patch so I want to fold it to [1] before Andrew is going > to send [1] to Linus. > > Thanks. Done. Thanks, Hui