Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752018AbdHPI60 (ORCPT ); Wed, 16 Aug 2017 04:58:26 -0400 Received: from mail-wm0-f51.google.com ([74.125.82.51]:36772 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751389AbdHPI6X (ORCPT ); Wed, 16 Aug 2017 04:58:23 -0400 Date: Wed, 16 Aug 2017 10:58:15 +0200 From: Corentin Labbe To: Fabien DESSENNE Cc: "herbert@gondor.apana.org.au" , "davem@davemloft.net" , "linux-crypto@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 2/3] crypto: engine - find request type with cra_type Message-ID: <20170816085815.GA5732@Red> References: <20170814131725.9402-1-clabbe.montjoie@gmail.com> <20170814131725.9402-3-clabbe.montjoie@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 631 Lines: 17 On Tue, Aug 15, 2017 at 07:51:14AM +0000, Fabien DESSENNE wrote: > Hi Corentin, > > Since I have just sent a patch to add the support of "aead_request" to crypto engine, I am wondering if your proposed change (checking cra_type instead of crypto_tfm_alg_type) and mine are compatible. > It looks like they are (assuming we export crypto_aead_type): can you confirm? > BR > > Fabien. > Hello My change is incompatible with yours since I remove a switch(crypto_tfm_alg_type) that you use. Anyway you will need my change:) because you use ablkcipher which is obsolete and you need to convert to skcipher. regards Corentin Labbe