Date: Wed, 16 Aug 2017 11:21:39 +0200
From: Petr Mladek <pmladek@suse.com>
To: pierre kuo <vichy.kuo@gmail.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>, rostedt@goodmis.org,
        linux-kernel@vger.kernel.org
Subject: Re: [RFC V2] printk: add warning while drop partial text in msg
Message-ID: <20170816092139.GA30544@pathway.suse.cz>
References: <1501421870-12042-1-git-send-email-vichy.kuo@gmail.com>
 <20170801024303.GA469@jagdpanzerIV.localdomain>
 <CAOVJa8GND5AY=ruWQ8_H=utvwi5+-Xk0DgcU-MGeV0xagLKHgw@mail.gmail.com>
 <CAOVJa8EZc4iQ_sOmOR9B2V7C=iLf7gJzQ0XMXLGRkuQBPVz_Gw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAOVJa8EZc4iQ_sOmOR9B2V7C=iLf7gJzQ0XMXLGRkuQBPVz_Gw@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1272
Lines: 30

On Fri 2017-08-11 00:55:48, pierre kuo wrote:
> hi Sergey:
> (Please ignore previous mail, I apologize for pressing send button too early :)
> >> this is not the only place that can truncate the message.
> >> vprintk_emit() can do so as well /* vscnprintf() */. but
> >> I think we don't care that much. a user likely will  notice
> >> truncated messages. we report lost messages, because this
> >> is a completely different sort of problem.
> Usually people will more easily find message truncated from semantics
> by vscnprintf, since it brute force truncate input message by the
> upper limit of output buffer.

Do you see the problem in the real life, please?

I ask because msg_print_text() seems to be used carefully.

For example, syslog_idx is bumped in syslog_print() only when
the message fits into the buffer. It repeats the read with an
empty buffer until the bigger userspace buffer is full.

Also kmsg_dump_get_buffer() first checks the size of the messages.
Then it calls msg_print_text() only for messages that fit into
the buffer.

These functions are called from userspace. Of course, all messages
do not fit into the userspace buffer. But userspace repeats the read
until all messages are read. IMHO, nothing is really dropped here.

Best Regards,
Petr