Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751853AbdHPLKq (ORCPT ); Wed, 16 Aug 2017 07:10:46 -0400 Received: from ozlabs.org ([103.22.144.67]:42039 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751542AbdHPLKn (ORCPT ); Wed, 16 Aug 2017 07:10:43 -0400 From: Michael Ellerman To: Daniel Borkmann , ast@kernel.org Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] bpf: Update sysctl documentation to list all supported architectures In-Reply-To: <5993FFC9.8010206@iogearbox.net> References: <1502860557-20247-1-git-send-email-mpe@ellerman.id.au> <5993FFC9.8010206@iogearbox.net> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Wed, 16 Aug 2017 21:10:40 +1000 Message-ID: <8760dnu5sf.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1589 Lines: 43 Daniel Borkmann writes: > Hi Michael, > > On 08/16/2017 07:15 AM, Michael Ellerman wrote: >> The sysctl documentation states that the JIT is only available on >> x86_64, which is no longer correct. >> >> Update the list to include all architectures that enable HAVE_CBPF_JIT >> or HAVE_EBPF_JIT under some configuration. >> >> Signed-off-by: Michael Ellerman > > Thanks for the patch! > >> Documentation/sysctl/net.txt | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/sysctl/net.txt b/Documentation/sysctl/net.txt >> index 14db18c970b1..f68356024d09 100644 >> --- a/Documentation/sysctl/net.txt >> +++ b/Documentation/sysctl/net.txt >> @@ -36,8 +36,9 @@ bpf_jit_enable >> -------------- >> >> This enables Berkeley Packet Filter Just in Time compiler. >> -Currently supported on x86_64 architecture, bpf_jit provides a framework >> -to speed packet filtering, the one used by tcpdump/libpcap for example. >> +Currently supported on arm, arm64, mips, powerpc, s390, sparc and x86_64 >> +architectures, bpf_jit provides a framework to speed packet filtering, the one >> +used by tcpdump/libpcap for example. > > Good point, could we actually make that as a bullet list and > differentiate between cBPF and eBPF JITs, so that a user doesn't > need to run git grep HAVE_{E,C}BPF_JIT to figure it out what the > switch enables on the arch used? That would be great. We could. Does a user of the sysctl want/need to know the difference though? Or do they just want to turn on "the JIT"? cheers