Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751882AbdHPLW4 (ORCPT ); Wed, 16 Aug 2017 07:22:56 -0400 Received: from mail-wr0-f193.google.com ([209.85.128.193]:38362 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751196AbdHPLWy (ORCPT ); Wed, 16 Aug 2017 07:22:54 -0400 From: Paolo Bonzini To: linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: "Michael S . Tsirkin" , =?UTF-8?q?Radim=20Kr=C4=8Dm=C3=A1=C5=99?= , stable@vger.kernel.org Subject: [PATCH] kvm: x86: disable KVM_FAST_MMIO_BUS Date: Wed, 16 Aug 2017 13:22:49 +0200 Message-Id: <20170816112249.28939-1-pbonzini@redhat.com> X-Mailer: git-send-email 2.13.5 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2020 Lines: 48 Microsoft pointed out privately to me that KVM's handling of KVM_FAST_MMIO_BUS is invalid. Using skip_emulation_instruction is invalid in EPT misconfiguration vmexit handlers, because neither EPT violations nor misconfigurations are listed in the manual among the VM exits that set the VM-exit instruction length field. While physical processors seem to set the field, this is not architectural and is just a side effect of the implementation. I couldn't convince myself of any condition on the exit qualification where VM-exit instruction length "has" to be defined; there are no trap-like VM-exits that can be repurposed; and fault-like VM-exits such as descriptor-table exits provide no decoding information. So I don't really see any elegant way to fix it except by disabling KVM_FAST_MMIO_BUS, which means virtio 1 will go slower. Adding a hypercall or MSR write that does a fast MMIO write to a physical address would do it, but it adds hypervisor knowledge in virtio, including CPUID handling. So it would be pretty ugly in the guest-side implementation, but if somebody wants to do it and the virtio side is acceptable to the virtio maintainers, I am okay with it. Cc: Michael S. Tsirkin Cc: Radim Krčmář Cc: stable@vger.kernel.org Fixes: 68c3b4d1676d870f0453c31d5a52e7e65c7448ae Signed-off-by: Paolo Bonzini --- arch/x86/kvm/vmx.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c index 375dca24cf42..b3eaeb20670d 100644 --- a/arch/x86/kvm/vmx.c +++ b/arch/x86/kvm/vmx.c @@ -6320,11 +6320,6 @@ static int handle_ept_misconfig(struct kvm_vcpu *vcpu) gpa_t gpa; gpa = vmcs_read64(GUEST_PHYSICAL_ADDRESS); - if (!kvm_io_bus_write(vcpu, KVM_FAST_MMIO_BUS, gpa, 0, NULL)) { - trace_kvm_fast_mmio(gpa); - return kvm_skip_emulated_instruction(vcpu); - } - ret = handle_mmio_page_fault(vcpu, gpa, true); vcpu->arch.gpa_available = true; if (likely(ret == RET_MMIO_PF_EMULATE)) -- 2.13.5