Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751848AbdHPLo6 (ORCPT ); Wed, 16 Aug 2017 07:44:58 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:33232 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751611AbdHPLo5 (ORCPT ); Wed, 16 Aug 2017 07:44:57 -0400 From: Colin King To: Stuart Yoder , Laurentiu Tudor , Greg Kroah-Hartman , Wei Yongjun , devel@driverdev.osuosl.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] staging: fsl-mc: fix fsl_mc_is_allocatable strcmps Date: Wed, 16 Aug 2017 12:44:51 +0100 Message-Id: <20170816114451.1348-1-colin.king@canonical.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1138 Lines: 33 From: Colin Ian King The previous fix removed the equal to zero comparisons by the strcmps and now the function always returns true. Fix this by adding in the missing logical negation operators. Detected by CoverityScan, CID#1452267 ("Constant expression result") Fixes: b93ad9a067e1 ("staging: fsl-mc: be consistent when checking strcmp() return") Signed-off-by: Colin Ian King --- drivers/staging/fsl-mc/bus/fsl-mc-allocator.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/fsl-mc/bus/fsl-mc-allocator.c b/drivers/staging/fsl-mc/bus/fsl-mc-allocator.c index b37a6f48225f..8b5f2d0cdf06 100644 --- a/drivers/staging/fsl-mc/bus/fsl-mc-allocator.c +++ b/drivers/staging/fsl-mc/bus/fsl-mc-allocator.c @@ -16,9 +16,9 @@ static bool __must_check fsl_mc_is_allocatable(const char *obj_type) { - return strcmp(obj_type, "dpbp") || - strcmp(obj_type, "dpmcp") || - strcmp(obj_type, "dpcon"); + return !strcmp(obj_type, "dpbp") || + !strcmp(obj_type, "dpmcp") || + !strcmp(obj_type, "dpcon"); } /** -- 2.11.0