Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752678AbdHPMLJ (ORCPT ); Wed, 16 Aug 2017 08:11:09 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:32579 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751461AbdHPMKo (ORCPT ); Wed, 16 Aug 2017 08:10:44 -0400 Date: Wed, 16 Aug 2017 15:10:14 +0300 From: Dan Carpenter To: Colin King Cc: devel@driverdev.osuosl.org, Stuart Yoder , Greg Kroah-Hartman , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Wei Yongjun , Laurentiu Tudor Subject: Re: [PATCH] staging: fsl-mc: fix fsl_mc_is_allocatable strcmps Message-ID: <20170816121014.7bbeipqxxccx7okm@mwanda> References: <20170816114451.1348-1-colin.king@canonical.com> <20170816120654.p3mpezb3zr2eqxvw@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170816120654.p3mpezb3zr2eqxvw@mwanda> User-Agent: NeoMutt/20170113 (1.7.2) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 641 Lines: 18 On Wed, Aug 16, 2017 at 03:06:54PM +0300, Dan Carpenter wrote: > On Wed, Aug 16, 2017 at 12:44:51PM +0100, Colin King wrote: > > From: Colin Ian King > > > > The previous fix removed the equal to zero comparisons by the strcmps and > > now the function always returns true. Fix this by adding in the missing > > logical negation operators. > > > > Detected by CoverityScan, CID#1452267 ("Constant expression result") > > > > Fixes: b93ad9a067e1 ("staging: fsl-mc: be consistent when checking strcmp() return") > > Ugh... I did review the original patch at all. Sorry. s/did/did not/ regards, dan carpenter