Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752175AbdHPM3x (ORCPT ); Wed, 16 Aug 2017 08:29:53 -0400 Received: from ozlabs.org ([103.22.144.67]:42027 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752031AbdHPM3t (ORCPT ); Wed, 16 Aug 2017 08:29:49 -0400 X-powerpc-patch-notification: thanks X-powerpc-patch-commit: e611939fc8ec13387018df88083de7102a438730 In-Reply-To: <16ab841927ec607e16c37cbeff0aede21a27b8c3.1501679953.git.christophe.leroy@c-s.fr> To: Christophe Leroy , Benjamin Herrenschmidt , Paul Mackerras , Scott Wood , Balbir Singh From: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [v3, 1/5] powerpc/mm: Ensure change_page_attr() doesn't invalidate pinned TLBs Message-Id: <3xXTF82Lcmz9t4Z@ozlabs.org> Date: Wed, 16 Aug 2017 22:29:48 +1000 (AEST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 541 Lines: 15 On Wed, 2017-08-02 at 13:51:01 UTC, Christophe Leroy wrote: > __change_page_attr() uses flush_tlb_page(). > flush_tlb_page() uses tlbie instruction, which also invalidates > pinned TLBs, which is not what we expect. > > This patch modifies the implementation to use flush_tlb_kernel_range() > instead. This will make use of tlbia which will preserve pinned TLBs. > > Signed-off-by: Christophe Leroy Series applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/e611939fc8ec13387018df88083de7 cheers