Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752038AbdHPMzz (ORCPT ); Wed, 16 Aug 2017 08:55:55 -0400 Received: from mx2.suse.de ([195.135.220.15]:46602 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751695AbdHPMzy (ORCPT ); Wed, 16 Aug 2017 08:55:54 -0400 Subject: Re: [PATCH v3 3/5] reset: stm32: use the reset-simple driver To: Eugeniy Paltsev Cc: "p.zabel@pengutronix.de" , "linux-kernel@vger.kernel.org" , "alex.g@adaptrum.com" , "andre.przywara@arm.com" , "s.trumtrar@pengutronix.de" , "wens@csie.org" , "baoyou.xie@linaro.org" , "mcoquelin.stm32@gmail.com" , "dinguyen@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "alexandre.torgue@st.com" , "maxime.ripard@free-electrons.com" , "kernel@pengutronix.de" References: <20170816094701.30678-1-p.zabel@pengutronix.de> <20170816094701.30678-4-p.zabel@pengutronix.de> <1502887920.2586.35.camel@synopsys.com> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Organization: SUSE Linux GmbH Message-ID: <41f0ff01-84d4-e26b-c3fe-52accb7e0443@suse.de> Date: Wed, 16 Aug 2017 14:55:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1502887920.2586.35.camel@synopsys.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1011 Lines: 33 Hi Eugeniy, Am 16.08.2017 um 14:52 schrieb Eugeniy Paltsev: > On Wed, 2017-08-16 at 11:46 +0200, Philipp Zabel wrote: >> The reset-simple driver can be used without changes. >> >> Signed-off-by: Philipp Zabel >> [snip] >> >> --- a/drivers/reset/reset-simple.c >> +++ b/drivers/reset/reset-simple.c >> @@ -120,6 +120,7 @@ static const struct reset_simple_devdata >> reset_simple_active_low = { >> >> static const struct of_device_id reset_simple_dt_ids[] = { >> { .compatible = "altr,rst-mgr", .data = >> &reset_simple_socfpga }, >> + { .compatible = "st,stm32-rcc", }, >> { .compatible = "allwinner,sun6i-a31-clock-reset", >> .data = &reset_simple_active_low }, >> { /* sentinel */ }, > > What about adding generic compatible strings for future use? Please see 1/5 for the same discussion, raised by Andre and me. Thanks, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg)