Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751642AbdHPNEB (ORCPT ); Wed, 16 Aug 2017 09:04:01 -0400 Received: from foss.arm.com ([217.140.101.70]:35138 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751287AbdHPNEA (ORCPT ); Wed, 16 Aug 2017 09:04:00 -0400 Subject: Re: [PATCH v3 3/5] reset: stm32: use the reset-simple driver To: Eugeniy Paltsev , "p.zabel@pengutronix.de" Cc: "linux-kernel@vger.kernel.org" , "alex.g@adaptrum.com" , "s.trumtrar@pengutronix.de" , "wens@csie.org" , "baoyou.xie@linaro.org" , "mcoquelin.stm32@gmail.com" , "dinguyen@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "alexandre.torgue@st.com" , "afaerber@suse.de" , "maxime.ripard@free-electrons.com" , "kernel@pengutronix.de" References: <20170816094701.30678-1-p.zabel@pengutronix.de> <20170816094701.30678-4-p.zabel@pengutronix.de> <1502887920.2586.35.camel@synopsys.com> From: Andre Przywara Message-ID: Date: Wed, 16 Aug 2017 14:03:57 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1502887920.2586.35.camel@synopsys.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1625 Lines: 59 Hi, On 16/08/17 13:52, Eugeniy Paltsev wrote: > Hi Philipp, > > On Wed, 2017-08-16 at 11:46 +0200, Philipp Zabel wrote: >> The reset-simple driver can be used without changes. >> >> Signed-off-by: Philipp Zabel >> [snip] >> >> --- a/drivers/reset/reset-simple.c >> +++ b/drivers/reset/reset-simple.c >> @@ -120,6 +120,7 @@ static const struct reset_simple_devdata >> reset_simple_active_low = { >> >> static const struct of_device_id reset_simple_dt_ids[] = { >> { .compatible = "altr,rst-mgr", .data = >> &reset_simple_socfpga }, >> + { .compatible = "st,stm32-rcc", }, >> { .compatible = "allwinner,sun6i-a31-clock-reset", >> .data = &reset_simple_active_low }, >> { /* sentinel */ }, > > What about adding generic compatible strings for future use? Exactly ;-) (see my previous email) But we still need the pre-existing strings in here, of course. > I mean next: > > --------------------->8--------------------- > > static const struct of_device_id reset_simple_dt_ids[] = { > { .compatible = "reset-simple-active-low", > .data = &reset_simple_active_low }, > { .compatible = "reset-simple-active-high", > .data = &reset_simple_active_high }, Either that or maybe even better define a "simple-reset" string and add standard properties like "active-low". Cheers, Andre. > /* ... */ > { /* sentinel */ }, > }; > > static const struct reset_simple_devdata reset_simple_active_high = { > .active_low = false, > }; > > static const struct reset_simple_devdata reset_simple_active_low = { > .active_low = true, > }; > > --------------------->8--------------------- >