Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751798AbdHPNms (ORCPT ); Wed, 16 Aug 2017 09:42:48 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:56912 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751089AbdHPNmq (ORCPT ); Wed, 16 Aug 2017 09:42:46 -0400 Subject: Re: [PATCH v4 1/3] dt-bindings: i2c: Document the IBM CCF power supply version 1 To: Eddie James Cc: jdelvare@suse.com, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, corbet@lwn.net, "Edward A. James" References: <1502830355-502-1-git-send-email-eajames@linux.vnet.ibm.com> <1502830355-502-2-git-send-email-eajames@linux.vnet.ibm.com> From: Guenter Roeck Message-ID: <6d0edce7-5e96-b6d4-8503-cf0f27f72d51@roeck-us.net> Date: Wed, 16 Aug 2017 06:42:43 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1502830355-502-2-git-send-email-eajames@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1423 Lines: 45 On 08/15/2017 01:52 PM, Eddie James wrote: > From: "Edward A. James" > > Signed-off-by: Edward A. James > --- > .../devicetree/bindings/i2c/ibm,cffps1.txt | 21 +++++++++++++++++++++ Sorry, just noticed. Sorry for the piecemeal review :-(. The i2c directory is used for i2c controllers, not for other i2c devices. Please move to hwmon (and drop i2c from the subject). Thanks, Guenter > 1 file changed, 21 insertions(+) > create mode 100644 Documentation/devicetree/bindings/i2c/ibm,cffps1.txt > > diff --git a/Documentation/devicetree/bindings/i2c/ibm,cffps1.txt b/Documentation/devicetree/bindings/i2c/ibm,cffps1.txt > new file mode 100644 > index 0000000..f68a0a6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/i2c/ibm,cffps1.txt > @@ -0,0 +1,21 @@ > +Device-tree bindings for IBM Common Form Factor Power Supply Version 1 > +---------------------------------------------------------------------- > + > +Required properties: > + - compatible = "ibm,cffps1"; > + - reg = < I2C bus address >; : Address of the power supply on the > + I2C bus. > + > +Example: > + > + i2c-bus@100 { > + #address-cells = <1>; > + #size-cells = <0>; > + #interrupt-cells = <1>; > + < more properties > > + > + power-supply@68 { > + compatible = "ibm,cffps1"; > + reg = <0x68>; > + }; > + }; >