Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751810AbdHPN5y (ORCPT ); Wed, 16 Aug 2017 09:57:54 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:56596 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751461AbdHPN5w (ORCPT ); Wed, 16 Aug 2017 09:57:52 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E4A52600E2 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: "Reizer\, Eyal" Cc: Sebastian Reichel , "\,Tony Lindgren" , "linux-wireless\@vger.kernel.org" , "linux-kernel\@vger.kernel.org" , Julian Calaby Subject: Re: [v7 wlcore: add missing nvs file name info for wilink8 References: <8665E2433BC68541A24DFFCA87B70F5B36425E3C@DFRE01.ent.ti.com> <20170815130952.bknron5yuqsdlazb@earth> <8665E2433BC68541A24DFFCA87B70F5B36427AC2@DFRE01.ent.ti.com> Date: Wed, 16 Aug 2017 16:57:45 +0300 In-Reply-To: <8665E2433BC68541A24DFFCA87B70F5B36427AC2@DFRE01.ent.ti.com> (Eyal Reizer's message of "Wed, 16 Aug 2017 07:17:53 +0000") Message-ID: <87y3qj7gyu.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 567 Lines: 18 "Reizer, Eyal" writes: >> > + if (wl->fuse_oui_addr == 0 && wl->fuse_nic_addr == 0) { >> > + wl1271_warning("Fuse mac address is zero. using " >> > + "random mac\n"); >> >> This one should also go into one line. > > This will still exceed 80 characters. Is this still ok? Yes, it's ok that the _format string_ goes above 80 chars, but if there are paremeters you should split them to a separate line. Example: pr_debug("This is an example of a very long message which also prints few variables foo %d bar %d", foo, bar); -- Kalle Valo