Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752290AbdHPO2G (ORCPT ); Wed, 16 Aug 2017 10:28:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:41512 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751552AbdHPO2F (ORCPT ); Wed, 16 Aug 2017 10:28:05 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C5E8C22B5F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Wed, 16 Aug 2017 10:28:03 -0400 From: Steven Rostedt To: Pratyush Anand Cc: Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [PATCH] tracer: hwlat: allow to be default bootup tracer Message-ID: <20170816102803.06337f0b@gandalf.local.home> In-Reply-To: References: X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1074 Lines: 32 On Fri, 11 Aug 2017 17:01:21 +0530 Pratyush Anand wrote: > hwlat is not a production kernel tracer, however it can be used to > identify any HW latency issue during kernel boot as well.Therefore call > init_hwlat_tracer() though core_initcall() so that we can pass > ftrace=hwlat in kernel commandline parameter and we can have hwlat as > default bootup tracer. > > Signed-off-by: Pratyush Anand > --- > kernel/trace/trace_hwlat.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/trace/trace_hwlat.c b/kernel/trace/trace_hwlat.c > index d7c8e4ec3d9d..09f8f0950b6c 100644 > --- a/kernel/trace/trace_hwlat.c > +++ b/kernel/trace/trace_hwlat.c > @@ -630,4 +630,4 @@ __init static int init_hwlat_tracer(void) > > return 0; > } > -late_initcall(init_hwlat_tracer); > +core_initcall(init_hwlat_tracer); No that is not the right fix. hwlat tracer should not be called by core init. I already have a fix in linux-next. I'm doing some more code that needs testing before I send it to Linus. -- Steve