Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752376AbdHPPMX (ORCPT ); Wed, 16 Aug 2017 11:12:23 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:39886 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752294AbdHPPMT (ORCPT ); Wed, 16 Aug 2017 11:12:19 -0400 Subject: Re: [PATCH v4] xen: get rid of paravirt op adjust_exception_frame To: Juergen Gross , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org References: <20170811145448.5679-1-jgross@suse.com> Cc: hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com, luto@amacapital.net From: Boris Ostrovsky Message-ID: <7ff53f6c-2bac-e6f4-ac4a-e35bf5f78540@oracle.com> Date: Wed, 16 Aug 2017 11:11:56 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170811145448.5679-1-jgross@suse.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1321 Lines: 30 On 08/11/2017 10:54 AM, Juergen Gross wrote: > When running as Xen pv-guest the exception frame on the stack contains > %r11 and %rcx additional to the other data pushed by the processor. > > Instead of having a paravirt op being called for each exception type > prepend the Xen specific code to each exception entry. When running as > Xen pv-guest just use the exception entry with prepended instructions, > otherwise use the entry without the Xen specific code. > > Signed-off-by: Juergen Gross > --- > arch/x86/entry/entry_64.S | 23 ++------- > arch/x86/entry/entry_64_compat.S | 1 - > arch/x86/include/asm/paravirt.h | 5 -- > arch/x86/include/asm/paravirt_types.h | 4 -- > arch/x86/include/asm/proto.h | 3 ++ > arch/x86/include/asm/traps.h | 33 ++++++++++-- > arch/x86/kernel/asm-offsets_64.c | 1 - > arch/x86/kernel/paravirt.c | 3 -- > arch/x86/xen/enlighten_pv.c | 96 +++++++++++++++++++++++------------ > arch/x86/xen/irq.c | 3 -- > arch/x86/xen/xen-asm_64.S | 45 ++++++++++++++-- > arch/x86/xen/xen-ops.h | 1 - > 12 files changed, 140 insertions(+), 78 deletions(-) Reviewed-by: Boris Ostrovsky Applied to for-linus-4.14. -boris