Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752353AbdHPR3F (ORCPT ); Wed, 16 Aug 2017 13:29:05 -0400 Received: from g4t3426.houston.hpe.com ([15.241.140.75]:59594 "EHLO g4t3426.houston.hpe.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752113AbdHPR3D (ORCPT ); Wed, 16 Aug 2017 13:29:03 -0400 From: "Kani, Toshimitsu" To: "bp@alien8.de" CC: "linux-kernel@vger.kernel.org" , "rostedt@goodmis.org" , "mchehab@kernel.org" , "rjw@rjwysocki.net" , "tony.luck@intel.com" , "lenb@kernel.org" , "linux-acpi@vger.kernel.org" , "linux-edac@vger.kernel.org" Subject: Re: [PATCH v2 4/7] ghes_edac: avoid multiple calls to dmi_walk() Thread-Topic: [PATCH v2 4/7] ghes_edac: avoid multiple calls to dmi_walk() Thread-Index: AQHTDKTuWyxK/OMe00e0Ovda8CeGBqJzlIKAgAEZcQCAAIyugIAD9yeAgAW2iQCABSfDgIAACkUAgAAEFwCAAAdxAIAACkmAgAAGWwCAAAC7gIAAB8WAgAAEpwCAAAu+AIAACWYAgAAIzwCAATq3AIAABjEAgAEXv4CAAHGnAIAAGBsAgAAKLgA= Date: Wed, 16 Aug 2017 17:28:50 +0000 Message-ID: <1502903940.2042.157.camel@hpe.com> References: <1502734083.2042.143.camel@hpe.com> <20170814183551.sgk2i7lxpmpyodhv@pd.tnic> <1502736750.2042.145.camel@hpe.com> <20170814193432.mjldfhfal5ba5dt7@pd.tnic> <1502741290.2042.147.camel@hpe.com> <20170814203942.6t3mrq3hc324blab@pd.tnic> <1502810766.2042.149.camel@hpe.com> <20170815154815.wy3dqwb4yi3feahg@intel.com> <20170816082931.p6rpvtlxwt5nccxr@pd.tnic> <1502896578.2042.155.camel@hpe.com> <20170816164234.mgwapenb7fpym6nk@pd.tnic> In-Reply-To: <20170816164234.mgwapenb7fpym6nk@pd.tnic> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=toshi.kani@hpe.com; x-originating-ip: [15.203.227.8] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DF4PR84MB0188;6:8MFkypTg2eaYjvedP7eO3smXsmyfBizcXZ9EwFiLOx+F01B4ir6aisdesUkYDzQcvsUjyOf12aTHg1cK/dCFYG2B17jUf9dpNthJNJ5kR44vWHcbYXB1hvWme7seyp7A23LgvSrZ7lmfiN1gUa9Cn1zlYYq8zwBP2A+VyCkwcagfAGBGak/Cee4hzSXu2SbVlf03TwoA/LdMes00T/KKxB2WUa6AVIIW01OLxd/181iu9zB7Eao8CE0i3z8n5jmIG+vr/hDPnMS5LXhtIpRgYYlsy1wUniNyqORWZ9+bPvt/7a5NFHrdYbLIPuXipFrO4jgZ9ou18hbiXbrl1Lb+8Q==;5:U9daaGKOAB6q3OisQYUqQTktWxgIBsonFqrokj28qzKFRxcohiu5BoL+NI1PyqgqBVmW82iNcLAg0ZBTnNnJZb5+LCLfvWehtLllmprnOyy672bB1I/uHNaGyPdqiMtuObolOh14K6YVqobJHUdjMg==;24:pT8GXt+xR/yUFQVqfkaQXOrXA/SSt+sl56c72Ne07DA/bx8U4EzXIHjkJaAst5CIYHy+5xie5zC5PDokg/zskz6C7ah/BeJbQkmnTjAuR4M=;7:lZCFJPVbVga208Los80OUi4XDvgaRZxHjAg3tGix6YQKBLYGbKjTL9fH0u8kYnYhzjUE3cVFna+zLdJmRm8kbzyix0CDQuCtLTP+CUAeQNYYgMIBhCxbgkXXH9KDcOPx6ePHxErGs7R7I0UHs1fMhXjrvE7+F6k0n0e6Oowm1zUCqDX9YQhd/Y0edIjgqAr/NwL8+9HWqtUAuvJ5TTbIFb92vwe8L5Bn7gn8vg5qduQ= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 601de620-1b1c-46c9-7724-08d4e4cc4231 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(48565401081)(2017052603031)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:DF4PR84MB0188; x-ms-traffictypediagnostic: DF4PR84MB0188: x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(3002001)(6055026)(6041248)(20161123560025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123564025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DF4PR84MB0188;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DF4PR84MB0188; x-forefront-prvs: 0401647B7F x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39860400002)(24454002)(189002)(199003)(377424004)(76176999)(54356999)(50986999)(2501003)(68736007)(6436002)(103116003)(189998001)(3846002)(102836003)(6916009)(2950100002)(6116002)(4326008)(478600001)(6506006)(81166006)(1730700003)(81156014)(66066001)(8936002)(6486002)(97736004)(8676002)(77096006)(101416001)(25786009)(2900100001)(106356001)(2906002)(14454004)(105586002)(86362001)(2351001)(33646002)(229853002)(7736002)(110136004)(5640700003)(305945005)(5660300001)(54906002)(53936002)(3280700002)(6246003)(36756003)(3660700001)(6512007)(93886005);DIR:OUT;SFP:1102;SCL:1;SRVR:DF4PR84MB0188;H:DF4PR84MB0187.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Aug 2017 17:28:50.0456 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-Transport-CrossTenantHeadersStamped: DF4PR84MB0188 X-OriginatorOrg: hpe.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v7GHTATx028943 Content-Length: 606 Lines: 16 On Wed, 2017-08-16 at 18:42 +0200, Borislav Petkov wrote: > On Wed, Aug 16, 2017 at 03:26:04PM +0000, Kani, Toshimitsu wrote: > > I believe you now need to protect from a race condition that a > > single mci and pvt can be initialized / consumed from multiple > > threads.  This protection is missing in your patch. > > Easy. Done. Assuming this big spinlock works, yes, this addresses my concern that it does not allow concurrent accesses to mci. :-) I will test the patch with an SCI when I got a chance. I won't be able to test other notification types or race conditions, though. Thanks, -Toshi