Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752358AbdHPSGj (ORCPT ); Wed, 16 Aug 2017 14:06:39 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:34510 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751692AbdHPSGi (ORCPT ); Wed, 16 Aug 2017 14:06:38 -0400 Date: Wed, 16 Aug 2017 11:06:35 -0700 (PDT) Message-Id: <20170816.110635.1062040564700704290.davem@davemloft.net> To: decui@microsoft.com Cc: netdev@vger.kernel.org, gregkh@linuxfoundation.org, devel@linuxdriverproject.org, kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com, georgezhang@vmware.com, jhansen@vmware.com, mkubecek@suse.cz, asias@redhat.com, stefanha@redhat.com, vkuznets@redhat.com, cavery@redhat.com, jasowang@redhat.com, rolf.neugebauer@docker.com, dave.scott@docker.com, marcelo.cerri@canonical.com, apw@canonical.com, olaf@aepfle.de, joe@perches.com, linux-kernel@vger.kernel.org, dan.carpenter@oracle.com Subject: Re: [PATCH net-next 1/3] VMCI: only load on VMware hypervisor From: David Miller In-Reply-To: References: X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 16 Aug 2017 11:06:37 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 427 Lines: 13 From: Dexuan Cui Date: Tue, 15 Aug 2017 22:13:29 +0000 > + /* > + * Check if we are running on VMware's hypervisor and bail out > + * if we are not. > + */ > + if (x86_hyper != &x86_hyper_vmware) > + return -ENODEV; This symbol is only available when CONFIG_HYPERVISOR_GUEST is defined. But this driver does not have a Kconfig dependency on that symbol so the build can fail in some configurations.