Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752479AbdHPScp (ORCPT ); Wed, 16 Aug 2017 14:32:45 -0400 Received: from mail-pg0-f68.google.com ([74.125.83.68]:32901 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751765AbdHPSco (ORCPT ); Wed, 16 Aug 2017 14:32:44 -0400 Date: Wed, 16 Aug 2017 11:32:40 -0700 From: Dmitry Torokhov To: Robin van der Gracht Cc: linux-kernel@vger.kernel.org, Miguel Ojeda Sandonis , linux-input@vger.kernel.org Subject: Re: [PATCH] auxdisplay: ht16k33: Use generic device properties function Message-ID: <20170816183240.GB25491@dtor-ws> References: <20170816102248.25498-1-robin@protonic.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170816102248.25498-1-robin@protonic.nl> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1417 Lines: 47 On Wed, Aug 16, 2017 at 12:22:48PM +0200, Robin van der Gracht wrote: > matrix_keypad_parse_of_params() was replaced early this year. > > Signed-off-by: Robin van der Gracht > --- > > Early this year Dmitry Torokhov introduced a switch to using generic > device properties instead of being OF-specific. > > Somehow this driver wasn't included in the update. It was outside of "input" tree so I did not update directly, so I kept the old name available. I meant to send a separate patch updating ht16k33, but I guess I forgot... FWIW Reviewed-by: Dmitry Torokhov I think you want to send it to GregKH as he was picking up the other ht16k33 patches. > > For reference: https://patchwork.kernel.org/patch/9527095/ > > drivers/auxdisplay/ht16k33.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/auxdisplay/ht16k33.c b/drivers/auxdisplay/ht16k33.c > index fbfa5b4cc567..99ce9731fc9c 100644 > --- a/drivers/auxdisplay/ht16k33.c > +++ b/drivers/auxdisplay/ht16k33.c > @@ -354,7 +354,7 @@ static int ht16k33_keypad_probe(struct i2c_client *client, > return err; > } > > - err = matrix_keypad_parse_of_params(&client->dev, &rows, &cols); > + err = matrix_keypad_parse_properties(&client->dev, &rows, &cols); > if (err) > return err; > if (rows > HT16K33_MATRIX_KEYPAD_MAX_ROWS || > -- > 2.11.0 > Thanks. -- Dmitry