Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752426AbdHPShQ (ORCPT ); Wed, 16 Aug 2017 14:37:16 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:35027 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751765AbdHPShO (ORCPT ); Wed, 16 Aug 2017 14:37:14 -0400 Subject: Re: [PATCH] xen/pvcalls: use WARN_ON(1) instead of __WARN() To: Stefano Stabellini , Arnd Bergmann References: <20170721161757.3336844-1-arnd@arndb.de> Cc: Juergen Gross , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org From: Boris Ostrovsky Message-ID: Date: Wed, 16 Aug 2017 14:36:55 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 812 Lines: 21 On 07/21/2017 03:26 PM, Stefano Stabellini wrote: > On Fri, 21 Jul 2017, Arnd Bergmann wrote: >> __WARN() is an internal helper that is only available on >> some architectures, but causes a build error e.g. on ARM64 >> in some configurations: >> >> drivers/xen/pvcalls-back.c: In function 'set_backend_state': >> drivers/xen/pvcalls-back.c:1097:5: error: implicit declaration of function '__WARN' [-Werror=implicit-function-declaration] >> >> Unfortunately, there is no equivalent of BUG() that takes no >> arguments, but WARN_ON(1) is commonly used in other drivers >> and works on all configurations. >> >> Fixes: 7160378206b2 ("xen/pvcalls: xenbus state handling") >> Signed-off-by: Arnd Bergmann > Reviewed-by: Stefano Stabellini > Applied to for-linus-4.14 -boris