Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752514AbdHPSuA (ORCPT <rfc822;w@1wt.eu>);
        Wed, 16 Aug 2017 14:50:00 -0400
Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:47736
        "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
        with ESMTP id S1751765AbdHPSt7 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 16 Aug 2017 14:49:59 -0400
Subject: Re: [PATCH] tools: fix compile error of freq-step.c
To: John Stultz <john.stultz@linaro.org>,
        Thomas Richter <tmricht@linux.vnet.ibm.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
        lkml <linux-kernel@vger.kernel.org>, brueckner@linux.vnet.ibm.com,
        Heiko Carstens <heiko.carstens@de.ibm.com>,
        Martin Schwidefsky <schwidefsky@de.ibm.com>,
        Shuah Khan <shuah@kernel.org>, Shuah Khan <shuahkh@osg.samsung.com>
References: <20170816060837.16612-1-tmricht@linux.vnet.ibm.com>
 <CALAqxLX3-uXqdjk6rjJ=OYNhacYYD089ZGPgWuWYO-Yg-y_xPQ@mail.gmail.com>
From: Shuah Khan <shuahkh@osg.samsung.com>
Message-ID: <94187ebe-6e8e-6d24-e798-7f038eaf83c8@osg.samsung.com>
Date: Wed, 16 Aug 2017 12:49:50 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <CALAqxLX3-uXqdjk6rjJ=OYNhacYYD089ZGPgWuWYO-Yg-y_xPQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1181
Lines: 34

On 08/16/2017 12:27 PM, John Stultz wrote:
> On Tue, Aug 15, 2017 at 11:08 PM, Thomas Richter
> <tmricht@linux.vnet.ibm.com> wrote:
>> The compilation of the file freq-step.c in directory
>> tools/testing/selftests/timers fails with this error message:
>>
>> [root@s8360046 timers]# make
>> gcc -O3 -Wl,-no-as-needed -Wall -DKTEST  -lrt -lpthread -lm  freq-step.c
>>           -o freq-step
>> freq-step.c: In function ‘init_test’:
>> freq-step.c:234:3: error: too few arguments to function ‘ksft_exit_skip’
>>    ksft_exit_skip();
>>    ^~~~~~~~~~~~~~
>> In file included from freq-step.c:26:0:
>> ../kselftest.h:142:19: note: declared here
>>  static inline int ksft_exit_skip(const char *msg, ...)
>>                    ^~~~~~~~~~~~~~
>> <builtin>: recipe for target 'freq-step' failed
>> make: *** [freq-step] Error 1
>> [root@s8360046 timers]#
>>
>> This is the case for Intel and s390x. I have not tested other
>> platforms.
>>
>> Which this patch the compilation succeeds:
> 
> I think Shuah has already submitted a fix for this to Linus.  I
> believe it was merged as 622b2fbe625b.
> 

Yes. It has been merged into mainline yesterday for 4.13-rc6 

thanks,
-- Shuah