Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752485AbdHPTQ5 (ORCPT ); Wed, 16 Aug 2017 15:16:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53306 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752026AbdHPTQ4 (ORCPT ); Wed, 16 Aug 2017 15:16:56 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com DACF576B28 Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jpoimboe@redhat.com Date: Wed, 16 Aug 2017 14:16:53 -0500 From: Josh Poimboeuf To: Juergen Gross Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, lguest@lists.ozlabs.org, boris.ostrovsky@oracle.com, hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com, rusty@rustcorp.com.au Subject: Re: [PATCH v2 1/2] paravirt,xen: remove xen_patch() Message-ID: <20170816191653.igbuzhmdrf2tqzrb@treble> References: <20170816173157.8633-1-jgross@suse.com> <20170816173157.8633-2-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170816173157.8633-2-jgross@suse.com> User-Agent: Mutt/1.6.0.1 (2016-04-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Wed, 16 Aug 2017 19:16:56 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 467 Lines: 17 On Wed, Aug 16, 2017 at 07:31:56PM +0200, Juergen Gross wrote: > ENTRY(xen_irq_disable_direct) > movb $1, PER_CPU_VAR(xen_vcpu_info) + XEN_vcpu_info_mask > -ENDPATCH(xen_irq_disable_direct) > ret > ENDPROC(xen_irq_disable_direct) > - RELOC(xen_irq_disable_direct, 0) Might as well remove the ENDPROC indentations while you're at it, for readability and consistency with other asm code. Otherwise, Reviewed-by: Josh Poimboeuf -- Josh