Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752527AbdHPUpp (ORCPT ); Wed, 16 Aug 2017 16:45:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:48328 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752384AbdHPUpn (ORCPT ); Wed, 16 Aug 2017 16:45:43 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 60AE222BEA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=robh@kernel.org MIME-Version: 1.0 In-Reply-To: <1502905525-5646-2-git-send-email-scott.branden@broadcom.com> References: <1502905525-5646-1-git-send-email-scott.branden@broadcom.com> <1502905525-5646-2-git-send-email-scott.branden@broadcom.com> From: Rob Herring Date: Wed, 16 Aug 2017 15:45:21 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/3] dt-bindings: mfd: d1w: iproc: Documentation for d1w driver To: Scott Branden Cc: Greg Kroah-Hartman , BCM Kernel Feedback , linux-arm-kernel , Linux Kernel Mailing List , Shreesha Rajashekar Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2115 Lines: 68 On Wed, Aug 16, 2017 at 12:45 PM, Scott Branden wrote: > From: Shreesha Rajashekar > > Adding document for IPROC d1w driver. > > Signed-off-by: Shreesha Rajashekar > Signed-off-by: Scott Branden > --- > .../devicetree/bindings/mfd/brcm,iproc-d1w.txt | 27 ++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/brcm,iproc-d1w.txt How is this an MFD? Should be bindings/w1/... > > diff --git a/Documentation/devicetree/bindings/mfd/brcm,iproc-d1w.txt b/Documentation/devicetree/bindings/mfd/brcm,iproc-d1w.txt > new file mode 100644 > index 0000000..2bb99c1 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/brcm,iproc-d1w.txt > @@ -0,0 +1,27 @@ > +* Broadcom Dallas One wire (D1W) bus master controller > + > +Required properties: > +- compatible : should be "brcm,iproc-d1w" > +- reg : Address and length of the register set for the device > +- interrupts : IRQ number of D1W controller > + > +Optional properties: > +- clocks : phandle of clock that supplies the module (required if platform > + clock bindings use device tree) > +- clock-names : name for the clock > +- clock-frequency : D1W divisor clock rate This should be bus-frequency. We messed up on I2C. > +- reset-recover-delay : Delay while reset D1W in milliseconds. Is this a standard 1-wire bus operation? I'm guessing so, but if not needs a vendor prefix. Also, needs unit suffix as defined in property-units.txt. > + > +Example: > + > +- From bcm-cygnus.dtsi: > +iproc_d1w: d1w@180ab000 { Should be a generic name. So far in bindings/w1/ we have 3 different ones in 3 bindings. Lets go with "onewire". > + compatible = "brcm,iproc_d1w"; Doesn't match the doc. > + reg = <0x180ab000 0x0f>; > + interrupts = ; > + clocks = <&axi81_clk>; > + clock-names = "iproc_d1w_clk"; > + clock-frequency = <100000000>; > + reset-recover-delay = <1>; > +}; > + > -- > 2.5.0 >