Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752414AbdHPUwr (ORCPT ); Wed, 16 Aug 2017 16:52:47 -0400 Received: from mx2.suse.de ([195.135.220.15]:43531 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752105AbdHPUwq (ORCPT ); Wed, 16 Aug 2017 16:52:46 -0400 Subject: Re: [PATCH v3 3/5] reset: stm32: use the reset-simple driver To: Alexandru Gagniuc Cc: Philipp Zabel , linux-kernel@vger.kernel.org, Andre Przywara , Maxime Coquelin , Alexandre Torgue , Maxime Ripard , Chen-Yu Tsai , Baoyou Xie , Eugeniy Paltsev , Steffen Trumtrar , Dinh Nguyen , linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de References: <20170816094701.30678-1-p.zabel@pengutronix.de> <20170816094701.30678-4-p.zabel@pengutronix.de> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Organization: SUSE Linux GmbH Message-ID: <338608e8-9e83-fc0f-8d8a-18a336e94860@suse.de> Date: Wed, 16 Aug 2017 22:52:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1397 Lines: 41 Am 16.08.2017 um 22:50 schrieb Alexandru Gagniuc: > On 08/16/2017 02:46 AM, Philipp Zabel wrote: >> The reset-simple driver can be used without changes. >> >> Signed-off-by: Philipp Zabel > > Reviewed-by: Alexandru Gagniuc > >> --- >> drivers/reset/Kconfig | 11 ++--- >> drivers/reset/Makefile | 1 - >> drivers/reset/reset-simple.c | 1 + >> drivers/reset/reset-stm32.c | 108 >> ------------------------------------------- >> 4 files changed, 4 insertions(+), 117 deletions(-) >> delete mode 100644 drivers/reset/reset-stm32.c >> >> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig >> index 78a8f6057985b..29f4487c290fc 100644 >> --- a/drivers/reset/Kconfig >> +++ b/drivers/reset/Kconfig >> @@ -70,19 +70,14 @@ config RESET_PISTACHIO >> >> config RESET_SIMPLE >> bool "Simple Reset Controller Driver" if COMPILE_TEST >> - default ARCH_SOCFPGA || ARCH_SUNXI >> + default ARCH_SOCFPGA || ARCH_STM32 || ARCH_SUNXI > > If this series gets respun, could you please look into removing the > ARCH_ dependency here? Why? It's not a dependency, just the default. Doing it here decouples it from having to do Kconfig changes in the arm-soc tree as well. Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany GF: Felix Imend?rffer, Jane Smithard, Graham Norton HRB 21284 (AG N?rnberg)