Subject: Re: [PATCH v3 3/5] reset: stm32: use the reset-simple driver
To: =?UTF-8?Q?Andreas_F=c3=a4rber?= <afaerber@suse.de>
References: <20170816094701.30678-1-p.zabel@pengutronix.de>
 <20170816094701.30678-4-p.zabel@pengutronix.de>
 <edbdf06c-fb1e-63f1-d6b2-17193c86385a@adaptrum.com>
 <338608e8-9e83-fc0f-8d8a-18a336e94860@suse.de>
Cc: Philipp Zabel <p.zabel@pengutronix.de>, linux-kernel@vger.kernel.org,
        Andre Przywara <andre.przywara@arm.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Alexandre Torgue <alexandre.torgue@st.com>,
        Maxime Ripard <maxime.ripard@free-electrons.com>,
        Chen-Yu Tsai <wens@csie.org>, Baoyou Xie <baoyou.xie@linaro.org>,
        Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
        Steffen Trumtrar <s.trumtrar@pengutronix.de>,
        Dinh Nguyen <dinguyen@kernel.org>,
        linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de
From: Alexandru Gagniuc <alex.g@adaptrum.com>
Message-ID: <d46ad9ea-4bf5-5ceb-cfc8-0c1efa48bb02@adaptrum.com>
Date: Wed, 16 Aug 2017 13:55:32 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <338608e8-9e83-fc0f-8d8a-18a336e94860@suse.de>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 8bit
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Aug 2017 20:55:36.1912 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR04MB0848
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1494
Lines: 47


On 08/16/2017 01:52 PM, Andreas F?rber wrote:
> Am 16.08.2017 um 22:50 schrieb Alexandru Gagniuc:
>> On 08/16/2017 02:46 AM, Philipp Zabel wrote:
>>> The reset-simple driver can be used without changes.
>>>
>>> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
>>
>> Reviewed-by: Alexandru Gagniuc <alex.g@adaptrum.com>
>>
>>> ---
>>>  drivers/reset/Kconfig        |  11 ++---
>>>  drivers/reset/Makefile       |   1 -
>>>  drivers/reset/reset-simple.c |   1 +
>>>  drivers/reset/reset-stm32.c  | 108
>>> -------------------------------------------
>>>  4 files changed, 4 insertions(+), 117 deletions(-)
>>>  delete mode 100644 drivers/reset/reset-stm32.c
>>>
>>> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
>>> index 78a8f6057985b..29f4487c290fc 100644
>>> --- a/drivers/reset/Kconfig
>>> +++ b/drivers/reset/Kconfig
>>> @@ -70,19 +70,14 @@ config RESET_PISTACHIO
>>>
>>>  config RESET_SIMPLE
>>>      bool "Simple Reset Controller Driver" if COMPILE_TEST
>>> -    default ARCH_SOCFPGA || ARCH_SUNXI
>>> +    default ARCH_SOCFPGA || ARCH_STM32 || ARCH_SUNXI
>>
>> If this series gets respun, could you please look into removing the
>> ARCH_ dependency here?
>
> Why?

Because the driver has to keep track of all its users, which is a 
layering violation.

> It's not a dependency, just the default. Doing it here decouples it
> from having to do Kconfig changes in the arm-soc tree as well.

Doing it here allows this list to grow without bounds.

> Regards,
> Andreas
>