Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752576AbdHPVha (ORCPT ); Wed, 16 Aug 2017 17:37:30 -0400 Received: from mail-vk0-f47.google.com ([209.85.213.47]:33317 "EHLO mail-vk0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752537AbdHPVh3 (ORCPT ); Wed, 16 Aug 2017 17:37:29 -0400 MIME-Version: 1.0 In-Reply-To: References: <20170816171211.4021-1-christian.brauner@ubuntu.com> <20170816194805.hnof3aqiqykwki7p@gmail.com> From: Christian Brauner Date: Wed, 16 Aug 2017 23:37:28 +0200 Message-ID: Subject: Re: [PATCH 0/1] devpts: use dynamic_dname() to generate proc name To: Linus Torvalds Cc: Christian Brauner , Linux Kernel Mailing List , "Serge E. Hallyn" , Al Viro Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1063 Lines: 31 On Wed, Aug 16, 2017 at 11:03 PM, Linus Torvalds wrote: > On Wed, Aug 16, 2017 at 1:30 PM, Linus Torvalds > wrote: >> >> I suspect the easiest fix is to just add a "mnt" argument to >> devpts_acquire(), It shouldn't be too painful. Let me try. > > Ok, here's a *very* lightly tested patch. It might have new bugs, but > it makes your test program DTRT. Cool. Very happy this could be fixed so quickly! > > Al, mind going over this and making sure I didn't miss anything? > > And Christian, if you can beat on this, that would be good. Yes, I can pound on this nicely with liblxc. We have patch ( https://github.com/lxc/lxc/pull/1728 ) up for review that allocates pty fds from private devpts mounts in different namespaces and sends those fds around between different namespaces. This was one of the original motivations for implementing TIOCGPTPEER. I had marked it as blocked until this bug was fixed which now seems to be the case. Thanks Linus! Christian > > Linus