Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752599AbdHPVzg (ORCPT ); Wed, 16 Aug 2017 17:55:36 -0400 Received: from mail-oi0-f68.google.com ([209.85.218.68]:35702 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752493AbdHPVzf (ORCPT ); Wed, 16 Aug 2017 17:55:35 -0400 MIME-Version: 1.0 In-Reply-To: References: <20170816171211.4021-1-christian.brauner@ubuntu.com> <20170816194805.hnof3aqiqykwki7p@gmail.com> From: Linus Torvalds Date: Wed, 16 Aug 2017 14:55:34 -0700 X-Google-Sender-Auth: 48jOSRiTynly4ncT4sR6-zhzpOw Message-ID: Subject: Re: [PATCH 0/1] devpts: use dynamic_dname() to generate proc name To: Christian Brauner Cc: Christian Brauner , Linux Kernel Mailing List , "Serge E. Hallyn" , Al Viro Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 760 Lines: 18 On Wed, Aug 16, 2017 at 2:45 PM, Linus Torvalds wrote: > > But it would be good to just test this in general too, and make sure I > didn't screw up some reference count or something. The patch *looks* > obviously correct, but ... Side note: I suspect it should be marked for stable, but it's going to be basically impossible to back-port this any further than 4.7 or something where we made each pts mount its own proper filesystem. The code before that was a mess, and this is never going to work right in old kernels. Of course, TIOCGPTPEER itself is much more recent than that and was done in this merge window, so hopefully you haven't backported it and expect this all to work in some older kernel? Linus