Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752588AbdHPWeG (ORCPT ); Wed, 16 Aug 2017 18:34:06 -0400 Received: from mail-pu1apc01on0127.outbound.protection.outlook.com ([104.47.126.127]:4102 "EHLO APC01-PU1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752431AbdHPWeE (ORCPT ); Wed, 16 Aug 2017 18:34:04 -0400 From: Dexuan Cui To: "Jorgen S. Hansen" CC: "davem@davemloft.net" , "netdev@vger.kernel.org" , "gregkh@linuxfoundation.org" , "devel@linuxdriverproject.org" , KY Srinivasan , "Haiyang Zhang" , Stephen Hemminger , George Zhang , Michal Kubecek , Asias He , Stefan Hajnoczi , "Vitaly Kuznetsov" , Cathy Avery , "jasowang@redhat.com" , Rolf Neugebauer , Dave Scott , "Marcelo Cerri" , "apw@canonical.com" , "olaf@aepfle.de" , "joe@perches.com" , "linux-kernel@vger.kernel.org" , Dan Carpenter Subject: RE: [PATCH net-next 1/3] VMCI: only load on VMware hypervisor Thread-Topic: [PATCH net-next 1/3] VMCI: only load on VMware hypervisor Thread-Index: AdMWE2FRTyA4wSwRRmSHRnOjNGe3sAAtLqAAAAWomqA= Date: Wed, 16 Aug 2017 22:33:43 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Ref=https://api.informationprotection.azure.com/api/72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Owner=decui@microsoft.com; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2017-08-16T15:33:39.7136512-07:00; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Application=Microsoft Azure Information Protection; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Extended_MSFT_Method=Automatic; Sensitivity=General authentication-results: spf=none (sender IP is ) smtp.mailfrom=decui@microsoft.com; x-originating-ip: [167.220.0.83] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;KL1P15301MB0005;6:6b6593/IoN++kGu58yfWY5rBfO6T8eT82WpscekT/MC/q8AELrLMW7NImDeKMM3yJI+FaY8cBVW6LQEftv2mbyAV++lz2u1ybIyPQVSbZgTDasM4AQ5vCe0q0nbltlY2IUlJNCsoCwC62zlREONWcF1uS/EONWf0WQtgtAd6jz8LrNrRFov85vkRVTc8v9LlX+Z7nB/B4tXSOLOJQ/UWdbSXp2ZeYmbNNwskf+BKGUBKePFsI8Pg/UWPaSzCdfDf8E2Dh0Vkr4loYBe9RSBDaHK8GTbgcZlSOQFwBSO6cUEv4xYTU1dLZH+LK+2w0XuM3+fgOf+2LTTXHI//CpOJqw==;5:9+t0vgjonnHMzu3xRNREmkvv0OnfVdt2y8ohbZJcYxHNEMxxp0hnkNPMpIHa6cI9mVuNI00i1SoEEOgK0o2MHTEikJkp9X7OB5rAz5jk1/ivjpLibyleXAwvlCojwO8UsvLV+zZNCY0GZ8FRrUnc0w==;24:hpe9crLOb4UN+sEGhJnaFjwU/a0u/uxybgjt6HPqGbcA/I2CUEDTc6cifVtEIGljTguXKC9pMQ290YA3roWOxEaNbh5Zmf74sCNtBobbBdU=;7:C8+nq7/8y0ugyVxK3DS+hfzGd5p3kKvaNG/HF74I3OyuVGdpHJTuS6KRogUSefFM2yCZ8T4cpggVfwcNJWfV8aK40vMGDS2YL2G7YPU9Ecj/CLue/98XUr7YW+NemHaep+E4BCvYSrTJ/TYaK4LZ8vp4PUZ+0GJKjoeHi7AMcV05/x4uRQq8CSkSwMUThK8LfD5ZkAfH+deOlfhviDLwAkxKyHr0jiBa4F0AgE6nv6I= x-ms-office365-filtering-correlation-id: c2f5c6b5-318d-49a4-931e-08d4e4f6da18 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(48565401081)(2017052603031)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:KL1P15301MB0005; x-ms-traffictypediagnostic: KL1P15301MB0005: x-exchange-antispam-report-test: UriScan:(61668805478150); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(61425038)(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(100000703101)(100105400095)(3002001)(6055026)(61426038)(61427038)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123564025)(20161123560025)(20161123555025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:KL1P15301MB0005;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:KL1P15301MB0005; x-forefront-prvs: 0401647B7F x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39860400002)(47760400005)(189002)(199003)(7416002)(66066001)(345774005)(6246003)(106356001)(97736004)(53936002)(55016002)(3846002)(54906002)(6116002)(105586002)(102836003)(2906002)(3280700002)(110136004)(189998001)(8676002)(7736002)(74316002)(14454004)(81156014)(8936002)(5660300001)(81166006)(9686003)(68736007)(7696004)(305945005)(229853002)(25786009)(54356999)(50986999)(10290500003)(76176999)(101416001)(6506006)(5005710100001)(10090500001)(8990500004)(86362001)(33656002)(6916009)(86612001)(2900100001)(3660700001)(6436002)(4326008)(478600001)(77096006)(2950100002);DIR:OUT;SFP:1102;SCL:1;SRVR:KL1P15301MB0005;H:KL1P15301MB0008.APCP153.PROD.OUTLOOK.COM;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Aug 2017 22:33:43.1026 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1P15301MB0005 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v7GMYCQK015869 Content-Length: 1336 Lines: 26 > From: Jorgen S. Hansen [mailto:jhansen@vmware.com] > > Without the patch, vmw_vsock_vmci_transport.ko and vmw_vmci.ko can > > automatically load when an application creates an AF_VSOCK socket. > > > > This is the expected good behavior on VMware hypervisor, but as we > > are going to add hv_sock.ko (i.e. Hyper-V transport for AF_VSOCK), we > > should make sure vmw_vsock_vmci_transport.ko doesn't load on Hyper-V, > > otherwise there is a -EBUSY conflict when both vmw_vsock_vmci_transport.ko > > and hv_sock.ko try to call vsock_core_init() on Hyper-V. > > The VMCI driver (vmw_vmci.ko) is used both by the VMware guest support > (VMware Tools primarily) and by our Workstation product. Always disabling the > VMCI driver on Hyper-V means that user won’t be able to run Workstation > nested in Linux VMs on Hyper-V. Since the VMCI driver itself isn’t the problem > here, maybe we could move the check to vmw_vsock_vmci_transport.ko? > Ideally, there should be some way for a user to have access to both protocols, > but for now disabling the VMCI socket transport for Hyper-V (possibly with a > module option to skip that check and always load it) but leaving the VMCI driver > functional would be better, > > Jorgen Thank you for explaining the background! Then I'll make a new patch, following your suggestion. -- Dexuan