Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752563AbdHPW6E (ORCPT ); Wed, 16 Aug 2017 18:58:04 -0400 Received: from mail-oi0-f67.google.com ([209.85.218.67]:38330 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752298AbdHPW6D (ORCPT ); Wed, 16 Aug 2017 18:58:03 -0400 MIME-Version: 1.0 In-Reply-To: <87pobvruzt.fsf@xmission.com> References: <20170816171211.4021-1-christian.brauner@ubuntu.com> <20170816194805.hnof3aqiqykwki7p@gmail.com> <87pobvruzt.fsf@xmission.com> From: Linus Torvalds Date: Wed, 16 Aug 2017 15:58:02 -0700 X-Google-Sender-Auth: ZdPCqRsWCHg0orIlpKKuPRaC4b4 Message-ID: Subject: Re: [PATCH 0/1] devpts: use dynamic_dname() to generate proc name To: "Eric W. Biederman" Cc: Christian Brauner , Christian Brauner , Linux Kernel Mailing List , "Serge E. Hallyn" , Al Viro Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 568 Lines: 19 On Wed, Aug 16, 2017 at 3:46 PM, Eric W. Biederman wrote: >> tty->link->driver_data = pts_path; >> >> retval = ptm_driver->ops->open(tty, filp); > ^^^^^^^ > > If this open fails the code jumps to err_put_path which falls > through into out_put_fsi. No it doesn't. err_path_put falls through to err_release, but that then does a "return retval;". It doesn't get to out_put_fsi. Now, I _do_ want people to check the release path, but I don't think this was it. Or am I blind and missing something? Linus