Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752524AbdHPXBN (ORCPT ); Wed, 16 Aug 2017 19:01:13 -0400 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:48347 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752298AbdHPXBM (ORCPT ); Wed, 16 Aug 2017 19:01:12 -0400 Subject: Re: [RFC][PATCH 2/2] selftests: timers: freq-step: Fix build warning To: Miroslav Lichvar , John Stultz Cc: lkml , Thomas Gleixner , Stephen Boyd , linux-kselftest@vger.kernel.org, Shuah Khan , Shuah Khan References: <1502744496-17863-1-git-send-email-john.stultz@linaro.org> <1502744496-17863-2-git-send-email-john.stultz@linaro.org> <20170815121120.GB8800@localhost> From: Shuah Khan Message-ID: <782f658d-6a32-8f6f-8757-d03f1ee29da3@osg.samsung.com> Date: Wed, 16 Aug 2017 17:01:07 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170815121120.GB8800@localhost> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 741 Lines: 30 Hi John, On 08/15/2017 06:11 AM, Miroslav Lichvar wrote: > On Mon, Aug 14, 2017 at 02:01:36PM -0700, John Stultz wrote: >> Fixes the following build warning: >> freq-step.c: In function ‘main’: >> freq-step.c:271:1: warning: control reaches end of non-void function [-Wreturn-type] > >> @@ -268,4 +268,6 @@ int main(int argc, char **argv) >> ksft_exit_fail(); This needs to be changes as well to return ksft_exit_fail(); >> >> ksft_exit_pass(); >> + >> + return 0; >> } > > It seems most tests use "return ksft_exit_pass();". Would that be > preferred over separate return? I don't have a preference. Let's go with "return ksft_exit_pass();" > > Both patches in this set look good to me. > > Thanks, > thanks, -- Shuah