MIME-Version: 1.0
In-Reply-To: <782f658d-6a32-8f6f-8757-d03f1ee29da3@osg.samsung.com>
References: <1502744496-17863-1-git-send-email-john.stultz@linaro.org>
 <1502744496-17863-2-git-send-email-john.stultz@linaro.org>
 <20170815121120.GB8800@localhost> <782f658d-6a32-8f6f-8757-d03f1ee29da3@osg.samsung.com>
From: John Stultz <john.stultz@linaro.org>
Date: Wed, 16 Aug 2017 16:10:41 -0700
Message-ID: <CALAqxLUVEx3WNY=HFCp3W=yOwUC3T5hZmYJTgm=e=5g-vk4=_g@mail.gmail.com>
Subject: Re: [RFC][PATCH 2/2] selftests: timers: freq-step: Fix build warning
To: Shuah Khan <shuahkh@osg.samsung.com>
Cc: Miroslav Lichvar <mlichvar@redhat.com>,
        lkml <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Stephen Boyd <sboyd@codeaurora.org>, linux-kselftest@vger.kernel.org,
        Shuah Khan <shuah@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit
Content-Length: 907
Lines: 29

On Wed, Aug 16, 2017 at 4:01 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote:
> Hi John,
>
> On 08/15/2017 06:11 AM, Miroslav Lichvar wrote:
>> On Mon, Aug 14, 2017 at 02:01:36PM -0700, John Stultz wrote:
>>> Fixes the following build warning:
>>> freq-step.c: In function ‘main’:
>>> freq-step.c:271:1: warning: control reaches end of non-void function [-Wreturn-type]
>>
>>> @@ -268,4 +268,6 @@ int main(int argc, char **argv)
>>>              ksft_exit_fail();
>
> This needs to be changes as well to return ksft_exit_fail();
>>>
>>>      ksft_exit_pass();
>>> +
>>> +    return 0;
>>>  }
>>
>> It seems most tests use "return ksft_exit_pass();". Would that be
>> preferred over separate return? I don't have a preference.
>
> Let's go with "return ksft_exit_pass();"

Thanks for the review, I've made both changes and I'll send these out
shortly with the rest of my 4.14 focused queue.

thanks
-john