Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752605AbdHPXvj (ORCPT ); Wed, 16 Aug 2017 19:51:39 -0400 Received: from out03.mta.xmission.com ([166.70.13.233]:36243 "EHLO out03.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752368AbdHPXvh (ORCPT ); Wed, 16 Aug 2017 19:51:37 -0400 From: ebiederm@xmission.com (Eric W. Biederman) To: Linus Torvalds Cc: Christian Brauner , Christian Brauner , Linux Kernel Mailing List , "Serge E. Hallyn" , Al Viro References: <20170816171211.4021-1-christian.brauner@ubuntu.com> <20170816194805.hnof3aqiqykwki7p@gmail.com> <87pobvruzt.fsf@xmission.com> Date: Wed, 16 Aug 2017 18:51:20 -0500 In-Reply-To: (Linus Torvalds's message of "Wed, 16 Aug 2017 15:58:02 -0700") Message-ID: <87ziazqdfr.fsf@xmission.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1di85x-0005iw-Ay;;;mid=<87ziazqdfr.fsf@xmission.com>;;;hst=in01.mta.xmission.com;;;ip=67.3.200.44;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX1/dbbDoszYk5MTSLyVKLVEAqIi0pCgQto4= X-SA-Exim-Connect-IP: 67.3.200.44 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.0 TVD_RCVD_IP Message was received from an IP address * 1.5 XMNoVowels Alpha-numberic number with no vowels * 0.7 XMSubLong Long Subject * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.4995] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa06 1397; Body=1 Fuz1=1 Fuz2=1] * 0.0 T_TooManySym_02 5+ unique symbols in subject * 0.0 T_TooManySym_03 6+ unique symbols in subject * 0.0 T_TooManySym_01 4+ unique symbols in subject X-Spam-DCC: XMission; sa06 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: **;Linus Torvalds X-Spam-Relay-Country: X-Spam-Timing: total 5681 ms - load_scoreonly_sql: 0.04 (0.0%), signal_user_changed: 2.6 (0.0%), b_tie_ro: 1.80 (0.0%), parse: 0.73 (0.0%), extract_message_metadata: 14 (0.2%), get_uri_detail_list: 0.90 (0.0%), tests_pri_-1000: 8 (0.1%), tests_pri_-950: 1.16 (0.0%), tests_pri_-900: 0.96 (0.0%), tests_pri_-400: 20 (0.4%), check_bayes: 19 (0.3%), b_tokenize: 7 (0.1%), b_tok_get_all: 5 (0.1%), b_comp_prob: 1.70 (0.0%), b_tok_touch_all: 3.5 (0.1%), b_finish: 0.63 (0.0%), tests_pri_0: 104 (1.8%), check_dkim_signature: 0.46 (0.0%), check_dkim_adsp: 3.6 (0.1%), tests_pri_500: 5527 (97.3%), poll_dns_idle: 5520 (97.2%), rewrite_mail: 0.00 (0.0%) Subject: Re: [PATCH 0/1] devpts: use dynamic_dname() to generate proc name X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 862 Lines: 27 Linus Torvalds writes: > On Wed, Aug 16, 2017 at 3:46 PM, Eric W. Biederman > wrote: >>> tty->link->driver_data = pts_path; >>> >>> retval = ptm_driver->ops->open(tty, filp); >> ^^^^^^^ >> >> If this open fails the code jumps to err_put_path which falls >> through into out_put_fsi. > > No it doesn't. > > err_path_put falls through to err_release, but that then does a > "return retval;". It doesn't get to out_put_fsi. *Blink* You are right I missed that. In which case I am concerned about failures that make it to err_release. Unless I am missing something (again) failures that jump to err_release won't call mntput and will result in a mnt leak. > Now, I _do_ want people to check the release path, but I don't think > this was it. Or am I blind and missing something? Eric