Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751853AbdHQBCj (ORCPT ); Wed, 16 Aug 2017 21:02:39 -0400 Received: from ozlabs.org ([103.22.144.67]:57041 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751490AbdHQBCi (ORCPT ); Wed, 16 Aug 2017 21:02:38 -0400 From: Rusty Russell To: Juergen Gross , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, lguest@lists.ozlabs.org Cc: boris.ostrovsky@oracle.com, hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com, Juergen Gross Subject: Re: [PATCH v2 0/2] x86: paravirt related cleanup In-Reply-To: <20170816173157.8633-1-jgross@suse.com> References: <20170816173157.8633-1-jgross@suse.com> Date: Thu, 17 Aug 2017 10:28:05 +0930 Message-ID: <87valnnh7m.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 5104 Lines: 115 Juergen Gross writes: > Cleanup special cases of paravirt patching: > > - Xen doesn't need a custom patching function, it can use > paravirt_patch_default() > > - Remove lguest completely from the tree. A LKML mail asking for any > users 3 months ago did not reveal any need for keeping lguest [1]. Shit, I didn't see that mail :( Posting on lkml is a terrible way to find users (you should generally remove the config option, wait a year, then see, as that gives end users time to find it). In this case though, I think it's time. I intended for it to be removed with the paravirt infrastructure itself, but I think that's getting closer anyway. Acked-by: Rusty Russell > In case the patches make it to the tree there is quite some potential > for further simplification of paravirt stuff. Especially most of the > pv operations can be put under the CONFIG_XEN_PV umbrella. > > Changes in V2: > - drop patch 3 (removal of vsmp support) > - patch 1: remove even more stuff no longer needed without xen_patch() > (Peter Zijlstra) > > [1]: https://lkml.org/lkml/2017/5/15/502 > > Juergen Gross (2): > paravirt,xen: remove xen_patch() > x86/lguest: remove lguest support > > MAINTAINERS | 11 - > arch/x86/Kbuild | 3 - > arch/x86/Kconfig | 2 - > arch/x86/include/asm/lguest.h | 91 - > arch/x86/include/asm/lguest_hcall.h | 74 - > arch/x86/include/asm/processor.h | 2 +- > arch/x86/include/uapi/asm/bootparam.h | 2 +- > arch/x86/kernel/asm-offsets_32.c | 20 - > arch/x86/kernel/head_32.S | 2 - > arch/x86/kernel/platform-quirks.c | 1 - > arch/x86/kvm/Kconfig | 1 - > arch/x86/lguest/Kconfig | 14 - > arch/x86/lguest/Makefile | 2 - > arch/x86/lguest/boot.c | 1558 --------------- > arch/x86/lguest/head_32.S | 192 -- > arch/x86/xen/enlighten_pv.c | 59 +- > arch/x86/xen/xen-asm.S | 24 +- > arch/x86/xen/xen-asm.h | 12 - > arch/x86/xen/xen-asm_32.S | 27 +- > arch/x86/xen/xen-asm_64.S | 20 +- > arch/x86/xen/xen-ops.h | 15 +- > drivers/Makefile | 1 - > drivers/block/Kconfig | 2 +- > drivers/char/Kconfig | 2 +- > drivers/char/virtio_console.c | 2 +- > drivers/lguest/Kconfig | 13 - > drivers/lguest/Makefile | 26 - > drivers/lguest/README | 47 - > drivers/lguest/core.c | 398 ---- > drivers/lguest/hypercalls.c | 304 --- > drivers/lguest/interrupts_and_traps.c | 706 ------- > drivers/lguest/lg.h | 258 --- > drivers/lguest/lguest_user.c | 446 ----- > drivers/lguest/page_tables.c | 1239 ------------ > drivers/lguest/segments.c | 228 --- > drivers/lguest/x86/core.c | 724 ------- > drivers/lguest/x86/switcher_32.S | 388 ---- > drivers/net/Kconfig | 2 +- > drivers/tty/hvc/Kconfig | 2 +- > drivers/virtio/Kconfig | 4 +- > include/linux/lguest.h | 73 - > include/linux/lguest_launcher.h | 44 - > include/uapi/linux/virtio_ring.h | 4 +- > tools/Makefile | 11 +- > tools/lguest/.gitignore | 2 - > tools/lguest/Makefile | 14 - > tools/lguest/extract | 58 - > tools/lguest/lguest.c | 3420 --------------------------------- > tools/lguest/lguest.txt | 125 -- > 49 files changed, 36 insertions(+), 10639 deletions(-) > delete mode 100644 arch/x86/include/asm/lguest.h > delete mode 100644 arch/x86/include/asm/lguest_hcall.h > delete mode 100644 arch/x86/lguest/Kconfig > delete mode 100644 arch/x86/lguest/Makefile > delete mode 100644 arch/x86/lguest/boot.c > delete mode 100644 arch/x86/lguest/head_32.S > delete mode 100644 arch/x86/xen/xen-asm.h > delete mode 100644 drivers/lguest/Kconfig > delete mode 100644 drivers/lguest/Makefile > delete mode 100644 drivers/lguest/README > delete mode 100644 drivers/lguest/core.c > delete mode 100644 drivers/lguest/hypercalls.c > delete mode 100644 drivers/lguest/interrupts_and_traps.c > delete mode 100644 drivers/lguest/lg.h > delete mode 100644 drivers/lguest/lguest_user.c > delete mode 100644 drivers/lguest/page_tables.c > delete mode 100644 drivers/lguest/segments.c > delete mode 100644 drivers/lguest/x86/core.c > delete mode 100644 drivers/lguest/x86/switcher_32.S > delete mode 100644 include/linux/lguest.h > delete mode 100644 include/linux/lguest_launcher.h > delete mode 100644 tools/lguest/.gitignore > delete mode 100644 tools/lguest/Makefile > delete mode 100644 tools/lguest/extract > delete mode 100644 tools/lguest/lguest.c > delete mode 100644 tools/lguest/lguest.txt > > -- > 2.12.3