Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752311AbdHQJA5 (ORCPT ); Thu, 17 Aug 2017 05:00:57 -0400 Received: from orcrist.hmeau.com ([104.223.48.154]:47620 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752270AbdHQJAy (ORCPT ); Thu, 17 Aug 2017 05:00:54 -0400 Date: Thu, 17 Aug 2017 17:00:36 +0800 From: Herbert Xu To: Pan Bian Cc: Tom Lendacky , Gary Hook , "David S. Miller" , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: crypto: ccp: use dma_mapping_error to check map error Message-ID: <20170817090036.GD25646@gondor.apana.org.au> References: <1502199767-2578-1-git-send-email-bianpan2016@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1502199767-2578-1-git-send-email-bianpan2016@163.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 494 Lines: 12 On Tue, Aug 08, 2017 at 09:42:47PM +0800, Pan Bian wrote: > The return value of dma_map_single() should be checked by > dma_mapping_error(). However, in function ccp_init_dm_workarea(), its > return value is checked against NULL, which could result in failures. > > Signed-off-by: Pan Bian Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt