Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752734AbdHQJUE (ORCPT ); Thu, 17 Aug 2017 05:20:04 -0400 Received: from foss.arm.com ([217.140.101.70]:46704 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752195AbdHQJT7 (ORCPT ); Thu, 17 Aug 2017 05:19:59 -0400 Subject: Re: [PATCH v3 3/5] reset: stm32: use the reset-simple driver To: Alexandru Gagniuc , =?UTF-8?Q?Andreas_F=c3=a4rber?= Cc: Philipp Zabel , linux-kernel@vger.kernel.org, Maxime Coquelin , Alexandre Torgue , Maxime Ripard , Chen-Yu Tsai , Baoyou Xie , Eugeniy Paltsev , Steffen Trumtrar , Dinh Nguyen , linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de References: <20170816094701.30678-1-p.zabel@pengutronix.de> <20170816094701.30678-4-p.zabel@pengutronix.de> <338608e8-9e83-fc0f-8d8a-18a336e94860@suse.de> From: Andre Przywara Message-ID: <74144e84-cd37-511a-9702-ceb590f37bf0@arm.com> Date: Thu, 17 Aug 2017 10:19:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Language: en-GB Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2307 Lines: 69 Hi, On 16/08/17 21:55, Alexandru Gagniuc wrote: > > > On 08/16/2017 01:52 PM, Andreas F?rber wrote: >> Am 16.08.2017 um 22:50 schrieb Alexandru Gagniuc: >>> On 08/16/2017 02:46 AM, Philipp Zabel wrote: >>>> The reset-simple driver can be used without changes. >>>> >>>> Signed-off-by: Philipp Zabel >>> >>> Reviewed-by: Alexandru Gagniuc >>> >>>> --- >>>> drivers/reset/Kconfig | 11 ++--- >>>> drivers/reset/Makefile | 1 - >>>> drivers/reset/reset-simple.c | 1 + >>>> drivers/reset/reset-stm32.c | 108 >>>> ------------------------------------------- >>>> 4 files changed, 4 insertions(+), 117 deletions(-) >>>> delete mode 100644 drivers/reset/reset-stm32.c >>>> >>>> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig >>>> index 78a8f6057985b..29f4487c290fc 100644 >>>> --- a/drivers/reset/Kconfig >>>> +++ b/drivers/reset/Kconfig >>>> @@ -70,19 +70,14 @@ config RESET_PISTACHIO >>>> >>>> config RESET_SIMPLE >>>> bool "Simple Reset Controller Driver" if COMPILE_TEST >>>> - default ARCH_SOCFPGA || ARCH_SUNXI >>>> + default ARCH_SOCFPGA || ARCH_STM32 || ARCH_SUNXI >>> >>> If this series gets respun, could you please look into removing the >>> ARCH_ dependency here? >> >> Why? > > Because the driver has to keep track of all its users, which is a > layering violation. "keep track of all its users": not necessarily, this is mostly for convenience reasons to get automatic coverage for those SoCs without changing various defconfigs - or distribution .configs, for that matter. Especially the latter may prove to be nasty and introduce regressions. But I see that this list may grow big and this is a bit beyond the scope of the otherwise neat "default ARCH_xxx" trick. So given the generic nature of this driver, can't we make this simply: "default ARM || ARM64" That would enable it everywhere automatically, but people can still disable this if they know what they do. Alternatively for ARM64 this is actually a candidate for the (one and only) defconfig. Cheers, Andre. >> It's not a dependency, just the default. Doing it here decouples it >> from having to do Kconfig changes in the arm-soc tree as well. > > Doing it here allows this list to grow without bounds. > >> Regards, >> Andreas >>