Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752029AbdHQKQa (ORCPT ); Thu, 17 Aug 2017 06:16:30 -0400 Received: from mail-wr0-f177.google.com ([209.85.128.177]:37096 "EHLO mail-wr0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751107AbdHQKPv (ORCPT ); Thu, 17 Aug 2017 06:15:51 -0400 Subject: Re: [alsa-devel] [PATCH v3 3/5] ASoC: codecs: msm8916-wcd-analog: add MBHC support To: Damien Riegel Cc: alsa-devel@alsa-project.org, Banajit Goswami , Patrick Lai , linux-kernel@vger.kernel.org, Takashi Iwai , Mark Brown References: <20170809164927.19663-1-srinivas.kandagatla@linaro.org> <20170809164927.19663-4-srinivas.kandagatla@linaro.org> <20170809211054.4owecfeoxxud5evh@workotop.localdomain> <76eb6edf-1754-6679-6218-028b12dce49a@linaro.org> <20170810133329.7lqcg3tucgp5jxii@workotop.localdomain> <20170814141222.rg3v3oqwt5xh3363@workotop.localdomain> <2731854d-c0fd-f8e3-456a-ba4d0d2e84c1@linaro.org> <20170816174840.sduoh2nm4hxye5jg@workotop.localdomain> From: Srinivas Kandagatla Message-ID: <74790f28-4b65-329c-bf8a-350480fc323b@linaro.org> Date: Thu, 17 Aug 2017 11:15:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170816174840.sduoh2nm4hxye5jg@workotop.localdomain> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 457 Lines: 12 On 16/08/17 18:48, Damien Riegel wrote: > Correct me if I'm wrong, but if the design is the same, the values > should be more a less the same as well, right? Moreover, the driver > detects the right key press in normal use cases. You are partly correct, but these values might change according to your board layout and there is button tuning procedure to derive these threshold values for each board according to OEM design requirements. thanks, srini