Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752167AbdHQKrZ (ORCPT ); Thu, 17 Aug 2017 06:47:25 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:3583 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751711AbdHQKrX (ORCPT ); Thu, 17 Aug 2017 06:47:23 -0400 Subject: Re: [PATCH v3] acpi: apei: fix the wrongly iterate generic error status block To: Borislav Petkov References: <1502871290-28137-1-git-send-email-gengdongjiu@huawei.com> <20170817092553.xcfbuplana2wbajb@pd.tnic> CC: , , , , , , , , , , , , , , , , From: gengdongjiu Message-ID: <25f9878c-932e-e400-ba06-6e61af41bbfd@huawei.com> Date: Thu, 17 Aug 2017 18:45:17 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <20170817092553.xcfbuplana2wbajb@pd.tnic> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.142.68.147] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090206.5995741F.002B,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 64c419b7eccd1689b869b811579f766f Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1295 Lines: 37 Borislav, thanks for the review, On 2017/8/17 17:25, Borislav Petkov wrote: > On Wed, Aug 16, 2017 at 04:14:50PM +0800, Dongjiu Geng wrote: >> The revision 0x300 generic error data entry is different >> from the old version, but currently iterating through the >> GHES estatus blocks does not take into account this difference. >> This will lead to failure to get the right data entry if GHES >> has revision 0x300 error data entry. >> >> Update the GHES estatus iteration to properly increment using > iteration macro > >> acpi_hest_get_next, and correct the iteration termination condition > Please end function names with parentheses. > >> because the status block data length only includes error data length. > <---- newline here. > >> Clear the CPER estatus printing iteration logic to use same macro. > s/Clear ... /Convert ... to the same macro./ > >> Signed-off-by: Dongjiu Geng >> CC: Tyler Baicar >> --- >> drivers/acpi/apei/apei-internal.h | 5 ----- >> drivers/firmware/efi/cper.c | 12 ++---------- >> include/acpi/ghes.h | 5 +++++ >> 3 files changed, 7 insertions(+), 15 deletions(-) > With those addressed you can add: Ok, I will add. > > Reviewed-by: Borislav Petkov > > --