Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752318AbdHQMVV (ORCPT ); Thu, 17 Aug 2017 08:21:21 -0400 Received: from mail-wr0-f193.google.com ([209.85.128.193]:33854 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751107AbdHQMVT (ORCPT ); Thu, 17 Aug 2017 08:21:19 -0400 MIME-Version: 1.0 In-Reply-To: <20170817103752.16440-1-colin.king@canonical.com> References: <20170817103752.16440-1-colin.king@canonical.com> From: Emil Velikov Date: Thu, 17 Aug 2017 13:21:17 +0100 Message-ID: Subject: Re: [Nouveau] [PATCH] drm/nouveau: remove redundant null check on array mstm->msto To: Colin King Cc: Ben Skeggs , David Airlie , ML dri-devel , ML nouveau , kernel-janitors@vger.kernel.org, "Linux-Kernel@Vger. Kernel. Org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1280 Lines: 29 On 17 August 2017 at 11:37, Colin King wrote: > From: Colin Ian King > > The check to see if mstm->msto is null is redundant because it is > an array and hence can never be null. Remove the redundant check. > > Detected by CoverityScan, CID#1375915 ("Array compared against 0") > > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/nouveau/nv50_display.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/nouveau/nv50_display.c b/drivers/gpu/drm/nouveau/nv50_display.c > index f7b4326a4641..51e9081b95a0 100644 > --- a/drivers/gpu/drm/nouveau/nv50_display.c > +++ b/drivers/gpu/drm/nouveau/nv50_display.c > @@ -3141,7 +3141,7 @@ nv50_mstc_new(struct nv50_mstm *mstm, struct drm_dp_mst_port *port, > mstc->connector.funcs->reset(&mstc->connector); > nouveau_conn_attach_properties(&mstc->connector); > > - for (i = 0; i < ARRAY_SIZE(mstm->msto) && mstm->msto; i++) > + for (i = 0; i < ARRAY_SIZE(mstm->msto); i++) I think that should be mstm->msto[i]. After all we are dereferencing the pointer, so we don't want to crash. > drm_mode_connector_attach_encoder(&mstc->connector, &mstm->msto[i]->encoder); -Emil