Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753148AbdHQMaE (ORCPT ); Thu, 17 Aug 2017 08:30:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:58888 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753001AbdHQMaA (ORCPT ); Thu, 17 Aug 2017 08:30:00 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D36CF20C51 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=shawnguo@kernel.org Date: Thu, 17 Aug 2017 20:28:18 +0800 From: Shawn Guo To: kgunda@codeaurora.org Cc: gregkh@linuxfoundation.org, sboyd@codeaurora.org, Abhijeet Dharmapurikar , David Collins , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-msm-owner@vger.kernel.org Subject: Re: [PATCH V2 11/12] spmi: pmic-arb: add support for HW version 5 Message-ID: <20170817122816.GB17549@dragon> References: <1501225847-27807-1-git-send-email-kgunda@codeaurora.org> <1501225847-27807-12-git-send-email-kgunda@codeaurora.org> <20170817074150.GA17549@dragon> <3d9ed27c23523965dae6706ff007f1b1@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3d9ed27c23523965dae6706ff007f1b1@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1387 Lines: 30 On Thu, Aug 17, 2017 at 03:38:30PM +0530, kgunda@codeaurora.org wrote: > The intention of this check is to avoid the access to the > peripherals those are > not owned by the current EE (APSS) and it is expected to return a > failure if the > peripheral that is not owned by the current EE is trying to be accessed. Thanks for the background of this check. > Looks like you trying to access the GPIOs 0xc000 and 0xc100, > which are owned by modem subsystem but not the APSS. That is why you > seeing the failure for that. > Please change the ownership of those GPIOs to APSS (id '0') if you > are working on a non-modem device (APQ). Yes, it's device apq8016-sbc, and the error message is like below. [ 1.317186] spmi spmi-0: PMIC arbiter version v2 (0x20010000) [ 1.324784] spmi spmi-0: failed to xlate sid = 0x0, periph = 0xc0, irq = 0: ee=0 but owner=2 [ 1.329430] spmi spmi-0: failed to xlate sid = 0x0, periph = 0xc0, irq = 0: ee=0 but owner=2 [ 1.337626] qcom-spmi-gpio: probe of 200f000.spmi:pm8916@0:gpios@c000 failed with error -22 I see that 'qcom,ee' property of spmi_bus is already <0>. Is that what you mean by ownership of those GPIOs? The pm8916_gpio is working fine on apq8016-sbc device with the current mainline kernel. It's not good to break the existing device without a very good. IMO, we should get this fixed before the patch is merged. Shawn