DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com C9F39AC2CF
Date: Thu, 17 Aug 2017 15:23:55 +0200
From: Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>, linux-kernel@vger.kernel.org,
        kvm@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] kvm: x86: disable KVM_FAST_MMIO_BUS
Message-ID: <20170817132354.GB2566@flask>
References: <20170816161301-mutt-send-email-mst@kernel.org>
 <fb384aa5-6b8a-4d70-98bb-2ce2adbcaab4@redhat.com>
 <20170816194342-mutt-send-email-mst@kernel.org>
 <81dabc78-edfd-32fc-024c-c57330386a51@redhat.com>
 <20170816190316.GA2566@flask>
 <20170816224815-mutt-send-email-mst@kernel.org>
 <ac5c6c7e-1738-b1c6-96eb-6bdf198b67d2@redhat.com>
 <20170817011815-mutt-send-email-mst@kernel.org>
 <2e42e64c-f31d-5ccd-2357-1a859cec5b5b@redhat.com>
 <2f80e82b-3007-0348-72b8-3391c7c57589@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2f80e82b-3007-0348-72b8-3391c7c57589@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1240
Lines: 28

2017-08-17 14:14+0200, Paolo Bonzini:
> On 17/08/2017 11:00, Paolo Bonzini wrote:
> > On 17/08/2017 00:31, Michael S. Tsirkin wrote:
> >> On Wed, Aug 16, 2017 at 11:25:35PM +0200, Paolo Bonzini wrote:
> >>> Yes, I agree.  EMULTYPE_SKIP is fine because failed decoding still
> >>> causes an exception to be injected.  Maybe it's better to gate the
> >>> EMULTYPE_SKIP emulation on the exit qualification saying this is a write
> >>
> >> I thought it's already limited to writes. I agree that's a reasonable
> >> limitation in any case.
> >>
> >>> and also not a page table walk---just in case.
> >>
> >> I still don't get it, sorry. Let's assume for the sake of argument
> >> that it's a PT walk causing the MMIO access. Just why do you think
> >> that it makes sense to skip the instruction that caused the walk?
> > 
> > I think it doesn't.  I think in that case it's better to skip the fast
> > write and proceed with full emulation.

It definitely doesn't.  I think it's possible only because virtio
forbids other access types, so we assume that every access is a write
access.

> ... nope, exit qualification is just zero for EPT misconfigurations, so
> we cannot do this.

Yeah, we'd need to use EPT violation to get that information.