Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752642AbdHQNty (ORCPT ); Thu, 17 Aug 2017 09:49:54 -0400 Received: from mail-it0-f44.google.com ([209.85.214.44]:37115 "EHLO mail-it0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751149AbdHQNtw (ORCPT ); Thu, 17 Aug 2017 09:49:52 -0400 MIME-Version: 1.0 X-Originating-IP: [149.6.131.75] In-Reply-To: <1502975140.2927.1.camel@pengutronix.de> References: <1481643559-19666-1-git-send-email-javier@osg.samsung.com> <1502975140.2927.1.camel@pengutronix.de> From: Javier Martinez Canillas Date: Thu, 17 Aug 2017 15:49:51 +0200 Message-ID: Subject: Re: [RFT PATCH] [media] partial revert of "[media] tvp5150: add HW input connectors support" To: Philipp Zabel Cc: Linux Kernel , Mauro Carvalho Chehab , Laurent Pinchart , Hans Verkuil , Linux Media Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1367 Lines: 38 Hello Philipp, On Thu, Aug 17, 2017 at 3:05 PM, Philipp Zabel wrote: > Hi, > > On Tue, 2016-12-13 at 12:39 -0300, Javier Martinez Canillas wrote: >> Commit f7b4b54e6364 ("[media] tvp5150: add HW input connectors support") >> added input signals support for the tvp5150, but the approach was found >> to be incorrect so the corresponding DT binding commit 82c2ffeb217a >> ("[media] tvp5150: document input connectors DT bindings") was reverted. >> >> This left the driver with an undocumented (and wrong) DT parsing logic, >> so lets get rid of this code as well until the input connectors support >> is implemented properly. >> >> It's a partial revert due other patches added on top of mentioned commit >> not allowing the commit to be reverted cleanly anymore. But all the code >> related to the DT parsing logic and input entities creation are removed. >> >> > Suggested-by: Laurent Pinchart >> > Signed-off-by: Javier Martinez Canillas > > what is the state of this patch? Was it forgotten or was the revert > deemed unnecessary? > I think that was just forgotten. That code still needs to be reverted since the DT patch was also reverted. Albeit the code is harmless since should be a no-op if a connectors DT node isn't found. > regards > Philipp > Best regards, Javier