Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752909AbdHQOEV (ORCPT ); Thu, 17 Aug 2017 10:04:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:39598 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751684AbdHQOET (ORCPT ); Thu, 17 Aug 2017 10:04:19 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DCCB821482 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=shawnguo@kernel.org Date: Thu, 17 Aug 2017 22:02:36 +0800 From: Shawn Guo To: yinbo.zhu@nxp.com Cc: linux-devel@gforge.freescale.net, Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , Harninder Rai , Yuantian Tang , "open list:" , Ashish Kumar , open list , Raghav Dogra , "moderated list:" Subject: Re: [PATCH] arm64: dts: ls1088a: Add USB support Message-ID: <20170817140232.GE7608@dragon> References: <1502938358-23522-1-git-send-email-yinbo.zhu@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1502938358-23522-1-git-send-email-yinbo.zhu@nxp.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2224 Lines: 82 On Thu, Aug 17, 2017 at 10:52:38AM +0800, yinbo.zhu@nxp.com wrote: > From: "yinbo.zhu" > > Fix the issue that usb is not detected on ls1088ardb > > Signed-off-by: yinbo.zhu > Signed-off-by: Ran Wang > --- > arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts | 8 ++++++++ > arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 18 ++++++++++++++++++ > 2 files changed, 26 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts > index e9276a5..949cd67 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts > @@ -145,6 +145,14 @@ > status = "okay"; > }; > > +&usb0 { > + status = "okay"; > +}; > + > +&usb1 { > + status = "okay"; > +}; > + > &esdhc { > status = "okay"; > }; Sort the labelled node alphabetically. > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > index 3a3be87..0dbff29 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > @@ -458,6 +458,24 @@ > status = "disabled"; > }; > > + usb0: usb3@3100000 { > + compatible = "snps,dwc3"; > + reg = <0x0 0x3100000 0x0 0x10000>; > + interrupts = <0 80 0x4>; /* Level high type */ Use IRQ_TYPE_LEVEL_HIGH, so that you can save the comment. > + dr_mode = "host"; > + configure-gfladj; What is this? I do not see it in upstream kernel. > + snps,dis_rxdet_inp3_quirk; You probably need a "disabled" status. Shawn > + }; > + > + usb1: usb3@3110000 { > + compatible = "snps,dwc3"; > + reg = <0x0 0x3110000 0x0 0x10000>; > + interrupts = <0 81 0x4>; /* Level high type */ > + dr_mode = "host"; > + configure-gfladj; > + snps,dis_rxdet_inp3_quirk; > + }; > + > sata: sata@3200000 { > compatible = "fsl,ls1088a-ahci"; > reg = <0x0 0x3200000 0x0 0x10000>, > -- > 2.1.0.27.g96db324 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel