Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753384AbdHQPLO (ORCPT ); Thu, 17 Aug 2017 11:11:14 -0400 Received: from mail-oi0-f65.google.com ([209.85.218.65]:33457 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753370AbdHQPLG (ORCPT ); Thu, 17 Aug 2017 11:11:06 -0400 MIME-Version: 1.0 In-Reply-To: <20170817140424.4614-1-gary.bisson@boundarydevices.com> References: <20170817140424.4614-1-gary.bisson@boundarydevices.com> From: Fabio Estevam Date: Thu, 17 Aug 2017 12:11:04 -0300 Message-ID: Subject: Re: [PATCH] ARM: imx_v6_v7_defconfig: Add CONFIG_FW_LOADER_USER_HELPER_FALLBACK To: Gary Bisson Cc: Shawn Guo , linux-kernel , Russell King - ARM Linux , Sascha Hauer , Fabio Estevam , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1172 Lines: 36 Hi Gary, On Thu, Aug 17, 2017 at 11:04 AM, Gary Bisson wrote: > Allows to load firmware files which aren't built inside the kernel. > > Especially useful for CODA firmware (vpu_fw_imx6q.bin) which is usually > located in the rootfs. > > Signed-off-by: Gary Bisson > --- > Hi Shawn, > > I'm not sure if this patch is acceptable since I've noticed that no > configuration currently has that option enabled (why?). > > As mentioned in the commit, I had to enable that in order to have CODA > load the VPU firmware properly. > > Another option would be to make the CODA driver a module... Yes, that's what we have currently: commit a5a56f07c2726cc801efccd23f8df29af04d6d19 Author: Fabio Estevam Date: Fri Jul 7 12:06:45 2017 -0300 ARM: imx_v6_v7_defconfig: Select the coda driver as module The coda driver may be probed prior to the rootfs being available, leading to firmware loading failure. To avoid such problem, select the coda driver as module. Signed-off-by: Fabio Estevam Signed-off-by: Shawn Guo